[FIX] Model: reject data that postdate the library version

Currently, if we try to load data that postdate tjhe library version,
the code will consider the data as "versionless" and will apply every
migration step to it, which makes no sense as the data already went
through those changes.

With this revision, we reject the data that postdate the library
version.

closes #8069

Task: 5895572
X-original-commit: 0bb9142
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Author: rrahir

src/migrations/data.ts

@@ -134,7 +134,14 @@ function compareVersions(v1: string, v2: string): number {
 function migrate(data: any): WorkbookData {
   const start = performance.now();
   const versions = getSortedVersions();
-  const index = versions.findIndex((v) => v === data.version);
+  const index = versions.findIndex((v) => compareVersions(v, data.version) >= 0);
+  if (index === -1) {
+    throw new Error(
+      `Data version ${
+        data.version
+      } postdates the current version of o-spreadsheet (version ${getCurrentVersion()}). It cannot be loaded.`
+    );
+  }
   for (let i = index + 1; i < versions.length; i++) {
     const nextVersion = versions[i];
     data = migrationStepRegistry.get(nextVersion).migrate(data);

tests/model/model_import_export.test.ts

@@ -1218,3 +1218,15 @@ test("Update chart revisions contain the full definition pre 18.5.1", () => {
   const definition2 = model.getters.getChartDefinition("fig2") as LineChartDefinition;
   expect(definition2.dataSets).toEqual([{ dataRange: "B1:B3" }]);
 });
+
+test("Reject data import from data with a subsequent version", () => {
+  const futureVersion = (parseFloat(getCurrentVersion()) + 1).toString();
+  expect(() => new Model({ version: futureVersion })).toThrow(
+    `Data version ${futureVersion} postdates the current version of o-spreadsheet (version ${getCurrentVersion()}). It cannot be loaded.`
+  );
+});
+
+test("Accept data that predates the latest version while not being present in the migration steps", () => {
+  const previousVersion = "16.3.1";
+  expect(() => new Model({ version: previousVersion })).not.toThrow();
+});