Merge pull request #27 from oleks-dev/fix_click_path_autocomplete

fix dynamic options click path type to support properly the autocomplete

Author: oleks-dev

prich/cli/dynamic_command_group.py

@@ -36,16 +36,16 @@ def _load_dynamic_commands(self, ctx):
         self._commands_loaded = True
 
 
-def get_variable_type(variable_type: str) -> click.types:
-    type_mapping = {"str": click.STRING, "int": click.INT, "bool": click.BOOL, "path": click.Path}
+def get_click_variable_type(variable_type: str) -> click.types:
+    type_mapping = {"str": click.STRING, "int": click.INT, "bool": click.BOOL, "path": click.Path()}
     return type_mapping.get(variable_type.lower(), None)
 
 
 def create_dynamic_command(config, template: TemplateModel) -> click.Command:
     options = []
     for arg in template.variables if template.variables else []:
         arg_name = arg.name
-        arg_type = get_variable_type(arg.type)
+        arg_type = get_click_variable_type(arg.type)
         help_text = arg.description or f"{arg_name} option"
         cli_option = arg.cli_option or f"--{arg_name}"
         if cli_option in RESERVED_RUN_TEMPLATE_CLI_OPTIONS:
@@ -59,7 +59,7 @@ def create_dynamic_command(config, template: TemplateModel) -> click.Command:
                 click.Option([cli_option], type=arg_type, default=arg.default, required=arg.required, show_default=True,
                              help=help_text))
         elif arg.type.startswith("list["):
-            list_type = get_variable_type(arg.type.split('[')[1][:-1])
+            list_type = get_click_variable_type(arg.type.split('[')[1][:-1])
             if not list_type:
                 raise click.ClickException(f"Failed to parse list type for {arg.name}")
             options.append(

tests/test_engine.py

@@ -496,11 +496,11 @@ def test_render_prompt_fields():
     # assert llm_step.rendered_input == "prompt"
 
 def test_get_variable_type():
-    from prich.cli.dynamic_command_group import get_variable_type
-    assert get_variable_type("str") == click.STRING
-    assert get_variable_type("int") == click.INT
-    assert get_variable_type("bool") == click.BOOL
-    assert get_variable_type("path") == click.Path
+    from prich.cli.dynamic_command_group import get_click_variable_type
+    assert get_click_variable_type("str") == click.STRING
+    assert get_click_variable_type("int") == click.INT
+    assert get_click_variable_type("bool") == click.BOOL
+    assert type(get_click_variable_type("path")) == click.Path
 
 
 def test_create_dynamic_command(basic_config, template):