fix: expose --create-namespace for argo addon; set namespace during helm uninstall (#510)

Signed-off-by: Artur Shad Nik <[email protected]>

Author: arturshadnik

pkg/cmd/install/hubaddon/exec.go

@@ -169,6 +169,7 @@ func (o *Options) createNamespace() error {
 func (o *Options) runWithHelmClient(addon string) error {
 	if addon == argocdAddonName {
 		o.Helm.WithNamespace(argocdNamespace)
+		o.Helm.WithCreateNamespace(o.values.CreateNamespace)
 		if err := o.Helm.PrepareChart(repoName, url); err != nil {
 			return err
 		}

pkg/cmd/uninstall/hubaddon/exec.go

@@ -19,6 +19,7 @@ import (
 
 var (
 	argocdAddonName          = "argocd"
+	argocdNamespace          = "argocd"
 	argocdReleaseName        = "argocd-pull-integration"
 	policyFrameworkAddonName = "governance-policy-framework"
 )
@@ -148,6 +149,7 @@ func (o *Options) runWithHelmClient(addon string) error {
 	}
 
 	if addon == argocdAddonName {
+		o.Helm.WithNamespace(argocdNamespace)
 		if err := o.Helm.UninstallRelease(argocdReleaseName); err != nil {
 			return err
 		}

pkg/helpers/helm/helm.go

@@ -29,8 +29,9 @@ import (
 const HelmFlagSetAnnotation = "HelmSet"
 
 type Helm struct {
-	settings *cli.EnvSettings
-	values   *values.Options
+	settings        *cli.EnvSettings
+	values          *values.Options
+	createNamespace bool
 }
 
 func NewHelm() *Helm {
@@ -48,6 +49,10 @@ func (h *Helm) WithNamespace(ns string) {
 	h.settings.SetNamespace(ns)
 }
 
+func (h *Helm) WithCreateNamespace(createNS bool) {
+	h.createNamespace = createNS
+}
+
 func (h *Helm) AddFlags(fs *pflag.FlagSet) {
 	fs.StringArrayVarP(&h.values.ValueFiles, "values", "f", []string{}, "specify values in a YAML file")
 	fs.StringArrayVar(&h.values.Values, "set-string", []string{}, "set string for chart")
@@ -157,6 +162,7 @@ func (h *Helm) InstallChart(name, repo, chart string) {
 		log.Fatal(err)
 	}
 	client := action.NewInstall(actionConfig)
+	client.CreateNamespace = h.createNamespace
 
 	if client.Version == "" && client.Devel {
 		client.Version = ">0.0.0-0"