Skip to content

Commit efac7dc

Browse files
committed
Disable the probe type dropdown for beta probes
1 parent 1b0f6a8 commit efac7dc

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

OpenEphys.Onix1.Design/NeuropixelsV2eDialog.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ public NeuropixelsV2eDialog(IConfigureNeuropixelsV2 configureNode)
2626
InitializeComponent();
2727
Shown += FormShown;
2828

29+
bool isBeta = false;
30+
2931
if (configureNode is ConfigureNeuropixelsV2eBeta configureV2eBeta)
3032
{
33+
isBeta = true;
3134
ConfigureNode = new ConfigureNeuropixelsV2eBeta(configureV2eBeta);
3235
Text = Text.Replace("NeuropixelsV2e ", "NeuropixelsV2eBeta ");
3336
}
@@ -38,15 +41,15 @@ public NeuropixelsV2eDialog(IConfigureNeuropixelsV2 configureNode)
3841

3942
ProbeConfigurations = new List<NeuropixelsV2eProbeConfigurationDialog>
4043
{
41-
new(ConfigureNode.ProbeConfigurationA, ConfigureNode.GainCalibrationFileA, ConfigureNode.InvertPolarity)
44+
new(ConfigureNode.ProbeConfigurationA, ConfigureNode.GainCalibrationFileA, ConfigureNode.InvertPolarity, isBeta)
4245
{
4346
TopLevel = false,
4447
FormBorderStyle = FormBorderStyle.None,
4548
Dock = DockStyle.Fill,
4649
Parent = this,
4750
Tag = NeuropixelsV2Probe.ProbeA
4851
},
49-
new(ConfigureNode.ProbeConfigurationB, ConfigureNode.GainCalibrationFileB, ConfigureNode.InvertPolarity)
52+
new(ConfigureNode.ProbeConfigurationB, ConfigureNode.GainCalibrationFileB, ConfigureNode.InvertPolarity, isBeta)
5053
{
5154
TopLevel = false,
5255
FormBorderStyle = FormBorderStyle.None,

OpenEphys.Onix1.Design/NeuropixelsV2eProbeConfigurationDialog.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ public NeuropixelsV2ProbeConfiguration ProbeConfiguration
7878
/// <param name="configuration">A <see cref="NeuropixelsV2ProbeConfiguration"/> object holding the current configuration settings.</param>
7979
/// <param name="calibrationFile">String containing the path to the calibration file for this probe.</param>
8080
/// <param name="invertPolarity">Boolean denoting whether or not to invert the polarity of neural data.</param>
81-
public NeuropixelsV2eProbeConfigurationDialog(NeuropixelsV2ProbeConfiguration configuration, string calibrationFile, bool invertPolarity)
81+
/// <param name="isBeta">Boolean indicating if this is a beta probe or not.</param>
82+
public NeuropixelsV2eProbeConfigurationDialog(NeuropixelsV2ProbeConfiguration configuration, string calibrationFile, bool invertPolarity, bool isBeta)
8283
{
8384
InitializeComponent();
8485
Shown += FormShown;
@@ -103,7 +104,11 @@ public NeuropixelsV2eProbeConfigurationDialog(NeuropixelsV2ProbeConfiguration co
103104

104105
comboBoxProbeType.DataSource = Enum.GetValues(typeof(NeuropixelsV2ProbeType));
105106
comboBoxProbeType.SelectedItem = ProbeConfiguration.ProbeType;
106-
comboBoxProbeType.SelectedIndexChanged += SelectedProbeTypeChanged;
107+
108+
if (isBeta)
109+
comboBoxProbeType.Enabled = false;
110+
else
111+
comboBoxProbeType.SelectedIndexChanged += SelectedProbeTypeChanged;
107112

108113
comboBoxReference.DataSource = NeuropixelsV2ProbeConfiguration.FilterNeuropixelsV2ShankReference(ProbeConfiguration.ProbeType);
109114
comboBoxReference.SelectedItem = ProbeConfiguration.Reference;

OpenEphys.Onix1.Design/NeuropixelsV2eProbeConfigurationEditor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public override object EditValue(ITypeDescriptorContext context, IServiceProvide
3535

3636
bool isBeta = instance is ConfigureNeuropixelsV2eBeta;
3737

38-
using var editorDialog = new NeuropixelsV2eProbeConfigurationDialog(configuration, calibrationFile, instance.InvertPolarity);
38+
using var editorDialog = new NeuropixelsV2eProbeConfigurationDialog(configuration, calibrationFile, instance.InvertPolarity, isBeta);
3939

4040
if (isBeta)
4141
{

0 commit comments

Comments
 (0)