Skip to content

Standardize lookback_time unit interpretation in config for top_query_collection #43573

@sv-splunk

Description

@sv-splunk

Component(s)

receiver/sqlserver

Describe the issue you're reporting

As a standard, all type of interval values in collector config currently requires an 's' suffix to interpret the unit. But the recently introduced lookback_time in top_query_collection currently does not follow this pattern. This needs to be fixed to maintain consistency and avoid ambiguity in unit interpretation.

Example of current config:

top_query_collection:
      lookback_time: 3
      collection_interval: 3s
      max_query_sample_count: 1000 
      top_query_count: 200

Proposed solution:

top_query_collection:
      lookback_time: 3s
      collection_interval: 3s
      max_query_sample_count: 1000 
      top_query_count: 200

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions