Skip to content

Conversation

@pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Oct 17, 2025

Fix #43625

[Updated to correctly describe the problem]

The tools used in the lint target need to build the component and per manual tests the component fails to build if go build tries to use CGO

The issue didn't show up previously because the build and test workflow on Windows ARM already sets the environment variable CGO_ENABLED to 0. The fix here is to adopt the same approach and disable CGO for windows-11-arm.

For safety I will do a bogus change to trigger a run of the case that exposed the issue.

@pjanotti pjanotti requested a review from a team as a code owner October 17, 2025 17:30
@pjanotti pjanotti requested a review from dashpole October 17, 2025 17:30
@pjanotti pjanotti changed the title Fix tools for windows 11 arm [chore] Fix tools for windows 11 arm Oct 17, 2025
@pjanotti pjanotti added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 17, 2025
@pjanotti
Copy link
Contributor Author

🤔 we are "gomoddownloading" for scoped-tests if go cache was not found, I don't think we should do that ... anyway, separate issue

@pjanotti pjanotti marked this pull request as draft October 17, 2025 18:01
@pjanotti
Copy link
Contributor Author

Hum, it still failed, looking...

@songy23 songy23 added ci-cd CI, CD, testing, build issues Run Windows Enable running windows test on a PR labels Oct 17, 2025
@pjanotti
Copy link
Contributor Author

This CI failure is the same as open-telemetry/opentelemetry-collector#12422

@pjanotti pjanotti marked this pull request as ready for review October 20, 2025 15:01
@pjanotti
Copy link
Contributor Author

I want one more run with the bogus change to confirm that things are green... will remove right after it.

@songy23 songy23 merged commit 9908fcf into open-telemetry:main Oct 20, 2025
229 of 235 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 20, 2025
@pjanotti pjanotti deleted the fix-tools-for-windows-11-arm branch October 20, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI, CD, testing, build issues Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

receiver/datadog: windows 11 scoped tests fail

5 participants