-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[chore] Fix tools for windows 11 arm #43633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
songy23
merged 9 commits into
open-telemetry:main
from
pjanotti:fix-tools-for-windows-11-arm
Oct 20, 2025
Merged
[chore] Fix tools for windows 11 arm #43633
songy23
merged 9 commits into
open-telemetry:main
from
pjanotti:fix-tools-for-windows-11-arm
Oct 20, 2025
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 we are "gomoddownloading" for |
|
Hum, it still failed, looking... |
|
This CI failure is the same as open-telemetry/opentelemetry-collector#12422 |
|
I want one more run with the bogus change to confirm that things are green... will remove right after it. |
atoulme
approved these changes
Oct 20, 2025
atoulme
reviewed
Oct 20, 2025
This reverts commit 0aab8a0.
songy23
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-cd
CI, CD, testing, build issues
Run Windows
Enable running windows test on a PR
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43625
[Updated to correctly describe the problem]
The tools used in the
linttarget need to build the component and per manual tests the component fails to build ifgo buildtries to useCGOThe issue didn't show up previously because the build and test workflow on Windows ARM already sets the environment variable
CGO_ENABLEDto0. The fix here is to adopt the same approach and disableCGOforwindows-11-arm.For safety I will do a bogus change to trigger a run of the case that exposed the issue.