Skip to content

Commit 3089704

Browse files
authored
Remove built pdatagen before regenerating pdata (#13828)
The pdata definitions are now stored directly within pdatagen. So if we rely on the cached pdatagen binary, updates in the files will never be rebuilt. This wasn't an issue before #13398, as we used `go run` rather than a tool.
1 parent fb65c0f commit 3089704

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,12 @@ genproto_sub:
246246
@rm -rf $(OPENTELEMETRY_PROTO_SRC_DIR)/*
247247
@rm -rf $(OPENTELEMETRY_PROTO_SRC_DIR)/.* > /dev/null 2>&1 || true
248248

249+
remove-pdatagen:
250+
rm -f .tools/pdatagen
251+
249252
# Generate structs, functions and tests for pdata package. Must be used after any changes
250253
# to proto and after running `make genproto`
251-
genpdata: $(PDATAGEN)
254+
genpdata: remove-pdatagen $(PDATAGEN)
252255
$(PDATAGEN)
253256
$(MAKE) -C pdata fmt
254257

0 commit comments

Comments
 (0)