Skip to content

Conversation

@tongoss
Copy link
Contributor

@tongoss tongoss commented Sep 15, 2025

fix #7066

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.9%. Comparing base (a817caa) to head (12f6459).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7363     +/-   ##
=======================================
+ Coverage   85.7%   85.9%   +0.1%     
=======================================
  Files        289     289             
  Lines      25377   25382      +5     
=======================================
+ Hits       21773   21819     +46     
+ Misses      3223    3191     -32     
+ Partials     381     372      -9     
Files with missing lines Coverage Δ
exporters/prometheus/exporter.go 90.7% <100.0%> (+7.2%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tongoss tongoss force-pushed the feature/prometheus-exporter-error-handling branch from 0a224d0 to 098985d Compare September 15, 2025 03:06
@tongoss tongoss marked this pull request as ready for review September 15, 2025 03:17
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this on!

@tongoss tongoss marked this pull request as draft September 16, 2025 20:17
@MrAlias MrAlias added this to the v1.39.0 milestone Sep 18, 2025
@MrAlias
Copy link
Contributor

MrAlias commented Sep 25, 2025

@tongoss are you still able to work on this?

@tongoss
Copy link
Contributor Author

tongoss commented Sep 25, 2025

@tongoss are you still able to work on this?

@MrAlias , my sincere apologies for the delay. I am able to continue working on this. I will try to get PR ready for review by the end of this week.

@tongoss tongoss marked this pull request as ready for review September 26, 2025 00:52
@tongoss
Copy link
Contributor Author

tongoss commented Sep 26, 2025

@MrAlias , this PR is ready for another review.

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@MrAlias MrAlias merged commit 874c4c3 into open-telemetry:main Oct 9, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exporters/prometheus: improve error handling

3 participants