profiles: drop profile.comment_strindices (#729)

Follow up as open-telemetry/semantic-conventions#2861 go merged.

Signed-off-by: Florian Lehner <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>

Author: florianl

CHANGELOG.md

@@ -6,6 +6,7 @@ The full list of changes can be found in the compare view for the respective rel
 
 ### Changed
 
+- profiles: drop field profile.comment_strindices. [#729](https://github.com/open-telemetry/opentelemetry-proto/pull/729)
 - profiles: clarify the original payload field comments. [#722](https://github.com/open-telemetry/opentelemetry-proto/pull/722)
 - profiles: add a note about cardinality implications for attribute values. [#713](https://github.com/open-telemetry/opentelemetry-proto/pull/713)
 - profiles: rename line -> lines and sample -> samples since they are repeated fields. [#712](https://github.com/open-telemetry/opentelemetry-proto/pull/712)

opentelemetry/proto/profiles/v1development/profiles.proto

@@ -276,25 +276,19 @@ message Profile {
   ValueType period_type = 5;
   // The number of events between sampled occurrences.
   int64 period = 6;
-  // Free-form text associated with the profile. The text is displayed as is
-  // to the user by the tools that read profiles (e.g. by pprof). This field
-  // should not be used to store any machine-readable information, it is only
-  // for human-friendly content. The profile must stay functional if this field
-  // is cleaned.
-  repeated int32 comment_strindices = 7; // Indices into ProfilesDictionary.string_table.
 
   // A globally unique identifier for a profile. The ID is a 16-byte array. An ID with
   // all zeroes is considered invalid. It may be used for deduplication and signal
   // correlation purposes. It is acceptable to treat two profiles with different values
   // in this field as not equal, even if they represented the same object at an earlier
   // time.
   // This field is optional; an ID may be assigned to an ID-less profile in a later step.
-  bytes profile_id = 8;
+  bytes profile_id = 7;
 
   // The number of attributes that were discarded. Attributes
   // can be discarded because their keys are too long or because there are too many
   // attributes. If this value is 0, then no attributes were dropped.
-  uint32 dropped_attributes_count = 9;
+  uint32 dropped_attributes_count = 8;
 
   // The original payload format. See also original_payload. Optional, but the
   // format and the bytes must be set or unset together.
@@ -315,13 +309,13 @@ message Profile {
   // The original payload can be large in size, so including the original
   // payload should be configurable by the profiler or collector options. The
   // default behavior should be to not include the original payload.
-  string original_payload_format = 10;
+  string original_payload_format = 9;
   // The original payload bytes. See also original_payload_format. Optional, but
   // format and the bytes must be set or unset together.
-  bytes original_payload = 11;
+  bytes original_payload = 10;
 
   // References to attributes in attribute_table. [optional]
-  repeated int32 attribute_indices = 12;
+  repeated int32 attribute_indices = 11;
 }
 
 // A pointer from a profile Sample to a trace Span.