Skip to content

Conversation

xalvaine
Copy link
Contributor

@xalvaine xalvaine commented Jun 9, 2025

Changes

Fixes breaking type changes in @tanstack/react-query 5.80.0 release https://github.com/TanStack/query/releases/tag/v5.80.0

Commit with breaking changes: TanStack/query@efa963d

Guys from tanstack removed 4th generic parameter (TQueryFnData) which led to a type error in Options in UseInfiniteQueryMethod type

Screenshot 2025-06-09 at 20 18 45

What does this PR change? Link to any related issue(s).

How to Review

How can a reviewer review your changes? What should be kept in mind for this review?

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@xalvaine xalvaine requested a review from a team as a code owner June 9, 2025 17:20
@xalvaine xalvaine requested a review from kerwanp June 9, 2025 17:20
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for openapi-ts failed.

Name Link
🔨 Latest commit 7f79b00
🔍 Latest deploy log https://app.netlify.com/projects/openapi-ts/deploys/68996d4d00584f000825e62c

Copy link

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: 7f79b00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…y to ^5.80.0 and fix type error in UseInfiniteQueryOptions
@xalvaine xalvaine force-pushed the renovate/tanstack-query-monorepo branch from 620a786 to 255d5d0 Compare June 9, 2025 17:23
@xalvaine xalvaine changed the title fix(deps): update peer dependency @tanstack/react-query to ^5.80.0 fix(openapi-react-query): update peer dependency @tanstack/react-query to ^5.80.0 and fix type error in UseInfiniteQueryOptions Jun 9, 2025
@drwpow drwpow merged commit 4b2265a into openapi-ts:main Aug 11, 2025
7 of 11 checks passed
@benh-dug
Copy link

benh-dug commented Sep 23, 2025

Did this fix get included in a release? It seemed to have not been included in [email protected] that was released on the same day this was merged?

#2404

And isn't showing in the current release PR, or the release inbetween

#2453
#2421

Ahh, and in particular the change-set bot says there aren't any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants