Unable to add a new IP address with a different gateway than the existing gateway

[swe12345]

Problem:
Unable to add a new IP address with a different gateway than the existing gateway

Steps to recreate:
Add a new IP on eth1 with a different gateway than the existing IP using the curl command
curl -k -H "X-Auth-Token: $bmc_token" -H "Content-Type: application/json" -X PATCH -d '{"IPv4StaticAddresses":[{},{"Address": "xx.xx.xx.xx","SubnetMask": "xxx.xxx.xxx.xxx","Gateway":"yy.yy.yy.yy"}]}' https://$bmc/redfish/v1/Managers/bmc/EthernetInterfaces/eth1

Seeing that it is throwing 400 error and giving the error 'IPv4StaticAddresses/1/Gateway' couldn't be written as it is conflicting the value 'IPv4StaticAddresses/0/Gateway'

Expected Results:
Expecting that we must be able to modify the gateway.

[mdmillerii]

This is likely generated in bmcweb here https://github.com/openbmc/bmcweb/blob/a5f87d487143a5478528826bab72b9f5a093f305/redfish-core/lib/ethernet.hpp#L1638
Please check you have 75859: Fix setting gateways | https://gerrit.openbmc.org/c/openbmc/bmcweb/+/75859

[liudkevich-iurii]

Have similar issue.

I have a bmcweb with 75859: Fix setting gateways

When I have one address added via webui bmcweb sets GW from this address config as GW for all addresses on this interface:

"IPv4Addresses": [
    {
        "Address": "172.16.1.100",
        "AddressOrigin": "Static",
        "Gateway": "172.16.1.1",
        "SubnetMask": "255.255.255.0"
    }
],
"IPv4StaticAddresses": [
    {
        "Address": "172.16.1.100",
        "AddressOrigin": "Static",
        "Gateway": "172.16.1.1",
        "SubnetMask": "255.255.255.0"
    }
],

And if I try to add another IP with it's own GW -- all I have got will be 400 error about conflicting GW settings between new IP config and last saved IP config. BUT. after this error bmcweb will set all GW to 0.0.0.0:

"IPv4Addresses": [
    {
        "Address": "172.16.1.100",
        "AddressOrigin": "Static",
        "Gateway": "0.0.0.0",
        "SubnetMask": "255.255.255.0"
    }
],
"IPv4StaticAddresses": [
    {
        "Address": "172.16.1.100",
        "AddressOrigin": "Static",
        "Gateway": "0.0.0.0",
        "SubnetMask": "255.255.255.0"
    }
],

And after that I can successfully add same address, but any next attempt to add new IP will fail.

[swe12345]

@ratagupt @wak-google @mdmillerii @liudkevich-iurii So, What is the expected behaviour now?

[mdmillerii]

I expected the testcase described in #78 (comment) to work and setting to another value is incorrect. However I have not taken the time to confirm or address the behaviour. I was pointing out the error message described is generated in the bmcweb code even though the storage for the setting is managed in this repository.

Did you confirm you were also testing with the indicated commit? Can you include a specific testcase in your report ? Using non routeable addresses is fine and maintains privacy but eases the effort and reduces the chances of miscommunication. You should be able to test from a local machine that doesn't require a gateway to be used and isn't selected by the netmask before or after the change.

Have you alerted the author of the indicated commit or maintainers of the affected repository of your test results? Did you consider linking the issue in that repository?

[anoo1]

@raviteja-b could you help Sweta with defining her test cases and expected results following Milton's suggestions above? Thanks.

[raviteja-b]

@raviteja-b could you help Sweta with defining her test cases and expected results following Milton's suggestions above? Thanks.

Ok sure

[raviteja-b]

@ratagupt @wak-google @mdmillerii @liudkevich-iurii So, What is the expected behaviour now?

PATCH to an existing ip address works if there is only one IP configured on interface and no longer returns the error with this bmcweb commit 75859: Fix setting gateways
I understand that this issue opened for Multiple static ip address configuration test case.
Currently networkd supports only one gateway per each ethernet interface and when there is one static IP address assigned on interface with a gateway, its not going to allow you to add new IP address with different gateway to avoid override with new gateway which breaks existing static IP configuration. in this case if user wants to use different gateway ip address then first IP IP address gateway needs to be modified.
This is actually good option we have chosen instead of simply overriding existing gateway, it throws error saying there is conflict in gateway configuration.

Here is gerrit discussion
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/75859/3..16//COMMIT_MSG#b23

this is working as per our latest bmcweb changes

[mdmillerii]

this is working as per our latest bmcweb changes

This restriction and testcase might be acceptable, as the original report is vauge (for example is it one per system or interface?)

And if I try to add another IP with it's own GW -- all I have got will be 400 error about conflicting GW settings between new IP config and last saved IP config. BUT. after this error bmcweb will set all GW to 0.0.0.0:

Changing the setting on another rest object in response to an errounous add is never correct and violates at least two clauses of the redfish specification.

As the discussion stated, more test scenerios are needed

[raviteja-b]

And if I try to add another IP with it's own GW -- all I have got will be 400 error about conflicting GW settings between new IP config and last saved IP config. BUT. after this error bmcweb will set all GW to 0.0.0.0:

Changing the setting on another rest object in response to an errounous add is never correct and violates at least two clauses of the redfish specification.

As the discussion stated, more test scenerios are needed

I could not recreate this issue, its does not set GW to 0.0.0.0.

[swe12345]

Any update on the original issue we are seeing please, we are unable to add a new IP address with a different gateway than the existing gateway.
@ratagupt @wak-google @mdmillerii @liudkevich-iurii

[mdmillerii]

Read the above discussion. It's claimed it works as designed for the developer. There are no changes being developed.

If you are still experiencing problems you will need to provide detailed steps to reproduce. This includes the IP address for every interface.

If you need to hide corporate network addresses recreate using one of the locally administrated ranges. This should be recreated on a platform available to others such as a qemu model. Test with current upstream code.

Include all network interfaces available on the manager. The service only allows one default gateway for the whole system.

Also you need to monitor this issue and provide answers to our questions. This request was made 3 months ago and the last update was two months ago.