feat: Enable single stack deployments in Helm chart

Author: jochenseeber

chart/README.md

@@ -206,6 +206,7 @@ This removes all the Kubernetes components associated with the chart and deletes
 | io_engine.​target.​nvmf.​ptpl | Reservations Persist Through Power Loss State | `true` |
 | io_engine.&ZeroWidthSpace;target.&ZeroWidthSpace;nvmf.&ZeroWidthSpace;rdma | Enable RDMA Capability of Mayastor nvmf target to take RDMA connections if the cluster nodes have RDMA device(s) configured from RNIC. | <pre>{<br>"enabled":false<br>}</pre> |
 | io_engine.&ZeroWidthSpace;tolerations | Set tolerations, overrides global | `[]` |
+| ipFamily | IP family for services and bind addresses. Valid values: "ipv4", "ipv6", "both" (default). | `"both"` |
 | localpv-provisioner.&ZeroWidthSpace;enabled | Enables the openebs dynamic-localpv-provisioner. If disabled, modify etcd and loki storage class accordingly. | `true` |
 | localpv-provisioner.&ZeroWidthSpace;hostpathClass.&ZeroWidthSpace;enabled | Enable default hostpath localpv StorageClass. | `false` |
 | localpv-provisioner.&ZeroWidthSpace;localpv.&ZeroWidthSpace;priorityClassName | Set the PriorityClass for the LocalPV Hostpath provisioner Deployment. | `"{{ .Release.Name }}-cluster-critical"` |

chart/templates/_helpers.tpl

@@ -387,3 +387,38 @@ Usage:
     {{- end -}}
   {{- end -}}
 {{- end }}
+
+{{/*
+Generates ipFamilyPolicy and ipFamilies for Service specs based on the global ipFamily setting.
+Valid values: "ipv4", "ipv6", "both"
+*/}}
+{{- define "service_ip_family" -}}
+{{- if eq .Values.ipFamily "ipv4" }}
+ipFamilyPolicy: SingleStack
+ipFamilies:
+  - IPv4
+{{- else if eq .Values.ipFamily "ipv6" }}
+ipFamilyPolicy: SingleStack
+ipFamilies:
+  - IPv6
+{{- else if eq .Values.ipFamily "both" }}
+ipFamilyPolicy: PreferDualStack
+ipFamilies:
+  - IPv4
+  - IPv6
+{{- else }}
+{{- fail (printf "invalid ipFamily value %q -- valid values: ipv4, ipv6, both" .Values.ipFamily) -}}
+{{- end -}}
+{{- end -}}
+
+{{/*
+Returns the bind address based on ipFamily.
+ipv4 → "0.0.0.0", ipv6 or both → "::"
+*/}}
+{{- define "bind_address" -}}
+{{- if eq .Values.ipFamily "ipv4" -}}
+0.0.0.0
+{{- else -}}
+::
+{{- end -}}
+{{- end -}}

chart/templates/mayastor/agents/core/agent-core-deployment.yaml

@@ -53,7 +53,7 @@ spec:
             {{- end }}
             - "--cache-period={{ .Values.base.cache_poll_period }}"{{ if .Values.base.jaeger.enabled }}
             - "--jaeger={{ include "jaeger_url" . }}"{{ end }}
-            - "--grpc-server-addr=[::]:50051"
+            - "--grpc-server-addr=[{{ include "bind_address" . }}]:50051"
             - "--pool-commitment={{ .Values.agents.core.capacity.thin.poolCommitment }}"
             - "--snapshot-commitment={{ .Values.agents.core.capacity.thin.snapshotCommitment }}"
             - "--volume-commitment-initial={{ .Values.agents.core.capacity.thin.volumeCommitmentInitial }}"
@@ -107,7 +107,7 @@ spec:
           image: "{{ .Values.image.registry }}/{{ .Values.image.repo }}/{{ include "image_prefix" . }}-agent-ha-cluster:{{ default .Values.image.tag .Values.image.repoTags.controlPlane }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           args:
-            - "-g=[::]:50052"
+            - "-g=[{{ include "bind_address" . }}]:50052"
             - "--store=http://{{ include "etcdUrl" . }}"
             - "--core-grpc=https://{{ .Release.Name }}-agent-core:50051"{{ if .Values.base.jaeger.enabled }}
             - "--jaeger={{ include "jaeger_url" . }}"{{ end }}{{ if .Values.eventing.enabled }}

chart/templates/mayastor/agents/core/agent-core-service.yaml

@@ -7,6 +7,7 @@ metadata:
     {{ include "label_prefix" . }}/release: {{ .Release.Name }}
     {{ include "label_prefix" . }}/version: {{ .Chart.Version }}
 spec:
+  {{- include "service_ip_family" . | nindent 2 }}
   selector:
     app: agent-core
     {{ include "label_prefix" . }}/release: {{ .Release.Name }}

chart/templates/mayastor/apis/api-rest-deployment.yaml

@@ -47,7 +47,8 @@ spec:
           args:
             - "--dummy-certificates"
             - "--no-auth"
-            - "--http=[::]:8081"
+            - "--https=[{{ include "bind_address" . }}]:8080"
+            - "--http=[{{ include "bind_address" . }}]:8081"
             - "--request-timeout={{ .Values.base.default_req_timeout }}"{{ if .Values.base.jaeger.enabled }}
             - "--jaeger={{ include "jaeger_url" . }}"{{ end }}
             - "--core-grpc=https://{{ .Release.Name }}-agent-core:50051"

chart/templates/mayastor/apis/api-rest-service.yaml

@@ -7,6 +7,7 @@ metadata:
     {{ include "label_prefix" . }}/release: {{ .Release.Name }}
     {{ include "label_prefix" . }}/version: {{ .Chart.Version }}
 spec:
+  {{- include "service_ip_family" . | nindent 2 }}
   type: {{ .Values.apis.rest.service.type }}
   selector:
     app: api-rest

chart/templates/mayastor/io/io-engine-daemonset.yaml

@@ -153,7 +153,7 @@ spec:
             protocol: TCP
             name: metrics
         args:
-          - "--metrics-endpoint=[::]:{{ default 9502 .Values.base.metrics.port }}"
+          - "--metrics-endpoint=[{{ include "bind_address" . }}]:{{ default 9502 .Values.base.metrics.port }}"
           - "--grpc-port={{ default 10124 .Values.io_engine.port }}"
           - "--fmt-style={{ include "logFormat" . }}"
           - "--ansi-colors={{ .Values.base.logging.color }}"

chart/templates/mayastor/metrics/metrics-exporter-io-engine-service.yaml

@@ -8,6 +8,7 @@ metadata:
     {{ include "label_prefix" . }}/release: {{ .Release.Name }}
     {{ include "label_prefix" . }}/version: {{ .Chart.Version }}
 spec:
+  {{- include "service_ip_family" . | nindent 2 }}
   ports:
     - name: metrics
       port: 9502

chart/templates/mayastor/obs/stats-service.yaml

@@ -8,6 +8,7 @@ metadata:
     {{ include "label_prefix" . }}/release: {{ .Release.Name }}
     {{ include "label_prefix" . }}/version: {{ .Chart.Version }}
 spec:
+  {{- include "service_ip_family" . | nindent 2 }}
   ports:
     - port: 9090
       name: https

chart/values.yaml

@@ -55,6 +55,8 @@ earlyEvictionTolerations:
 # If any component has tolerations set, then it would override this value.
 # For external components like etcd, jaeger and loki, tolerations can only be set at component level.
 tolerations: [ ]
+# -- IP family for services and bind addresses. Valid values: "ipv4", "ipv6", "both" (default).
+ipFamily: "both"
 base:
   # -- Request timeout for rest & core agents
   default_req_timeout: 5s