Unit tests fail

[dstenger]

Currently, unit tests of the main branch fail:

mvn clean install
...
Results :

Failed tests: 
  VerifyTestNGController.doTestRun:69 Unexpected number of fail verdicts. expected:<0> but was:<2>

Tests run: 21, Failures: 1, Errors: 0, Skipped: 2

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

[dstenger]

The unit test failures are caused by a commit which has been done after revision 0.2 of this test suite.
See https://github.com/opengeospatial/ets-eo-geojson10/commits/main/ for the list of commits.

I propose to postpone the commits which have been done after revision 0.2 and to create revision 1.0 (Production release) without them. They will be part of revision 1.1 then.
Those commits have never been installed on Beta.
@ghobona Can you please check the new commits and do you agree with my proposal?

[dstenger]

New pull request was created for postponed commits: #13

[dstenger]

The unit test failures can be reproduced by using the branch of #13.

[bpross-52n]

The unit test fails IMHO, because the https://github.com/opengeospatial/ets-eo-geojson10/blob/commits11/src/main/resources/test-run-props.xml contains absolute paths for the iut and col parameters, e.g.

<entry key="col">file:///Users/ogckm/Documents/GitHub/ets-eo-geojson10/src/test/resources/example-1-seasat-collection.json</entry>

This file is used by the doTestRun() test of the VerifyTestNGController test class, but the path for iut is overwritten with a path to a test resource. The col parameter however is not overwritten and this leads to the two failures shown above.

The test-run-props.xml file of the main branch contains URLs for both iut and col parameter. Changing the path of the col parameter to something non existing would also result in the two failures and thus fail the unit test. As the issue does not appear on the main branch to be a technical one, I'd recommend to close this issue.

[ghobona]

Discussed 2025-12-01

@bpross-52n to modify the VerifyTestNGController class to use the example-1-seasat.json and example-1-seasat-collection.json files. Can use either classloader (e.g. getResourceAsStream) or direct retrieval via URL from GitHub.