heath check no store strategy

Signed-off-by: Mark Herwege <[email protected]>

Author: mherwege

bundles/org.openhab.core.io.rest.core/src/main/java/org/openhab/core/io/rest/core/internal/persistence/PersistenceResource.java

@@ -77,6 +77,7 @@
 import org.openhab.core.persistence.registry.PersistenceServiceConfiguration;
 import org.openhab.core.persistence.registry.PersistenceServiceConfigurationDTOMapper;
 import org.openhab.core.persistence.registry.PersistenceServiceConfigurationRegistry;
+import org.openhab.core.persistence.strategy.PersistenceStrategy;
 import org.openhab.core.types.State;
 import org.openhab.core.types.TypeParser;
 import org.openhab.core.types.UnDefType;
@@ -392,11 +393,17 @@ public Response httpGetPersistenceHealth(@Context HttpHeaders headers) {
                             PersistenceServiceProblem.PERSISTENCE_NO_ITEMS, serviceId, null, editable));
                 } else {
                     for (PersistenceItemConfiguration config : configs) {
-                        if (config.strategies().isEmpty()) {
-                            List<String> items = config.items().stream()
-                                    .map(PersistenceServiceConfigurationDTOMapper::persistenceConfigToString).toList();
+                        List<PersistenceStrategy> strategies = config.strategies();
+                        List<String> items = config.items().stream()
+                                .map(PersistenceServiceConfigurationDTOMapper::persistenceConfigToString).toList();
+                        if (strategies.isEmpty()) {
                             persistenceProblems.add(new PersistenceServiceProblem(
                                     PersistenceServiceProblem.PERSISTENCE_NO_STRATEGY, serviceId, items, editable));
+                        } else if (strategies.size() == 1
+                                && PersistenceStrategy.Globals.RESTORE.equals(strategies.get(0))) {
+                            persistenceProblems.add(new PersistenceServiceProblem(
+                                    PersistenceServiceProblem.PERSISTENCE_NO_STORE_STRATEGY, serviceId, items,
+                                    editable));
                         }
                     }
                 }

bundles/org.openhab.core.persistence/src/main/java/org/openhab/core/persistence/PersistenceServiceProblem.java

@@ -32,9 +32,10 @@ public record PersistenceServiceProblem(String reason, @Nullable String serviceI
         boolean editable) {
 
     // Reasons for persistence configuration problems.
-    // If one of these constants is used as reason, th UI can use these values to give a more descriptive message.
+    // If one of these constants is used as reason, the UI can use these values to give a more descriptive message.
     public static final String PERSISTENCE_NO_DEFAULT = "PERSISTENCE_NO_DEFAULT";
     public static final String PERSISTENCE_NO_CONFIG = "PERSISTENCE_SERVICE_NO_CONFIG";
     public static final String PERSISTENCE_NO_ITEMS = "PERSISTENCE_SERVICE_NO_ITEMS";
     public static final String PERSISTENCE_NO_STRATEGY = "PERSISTENCE_SERVICE_ITEMS_NO_STRATEGY";
+    public static final String PERSISTENCE_NO_STORE_STRATEGY = "PERSISTENCE_SERVICE_ITEMS_NO_STORE_STRATEGY";
 }