Skip to content

Commit bf6d77a

Browse files
authored
feat: the default notification.yml is not configured properly (#3168)
* pb * fix: Modifying other fields while setting IsPrivateChat does not take effect * fix: quote message error revoke * refactoring scheduled tasks * refactoring scheduled tasks * refactoring scheduled tasks * refactoring scheduled tasks * refactoring scheduled tasks * refactoring scheduled tasks * upgrading pkg tools * fix * fix * optimize log output * feat: support GetLastMessage * feat: support GetLastMessage * feat: s3 switch * feat: s3 switch * fix: GetUsersOnline * feat: SendBusinessNotification supported configuration parameters * feat: SendBusinessNotification supported configuration parameters * feat: SendBusinessNotification supported configuration parameters * feat: seq conversion failed without exiting * fix: DeleteDoc crash * fix: fill send time * fix: fill send time * fix: crash caused by withdrawing messages from users who have left the group * fix: user msg timestamp * seq read config * seq read config * fix: the source message of the reference is withdrawn, and the referenced message is deleted * feat: optimize the default notification.yml * fix: shouldPushOffline
1 parent 46f1a9c commit bf6d77a

File tree

2 files changed

+17
-14
lines changed

2 files changed

+17
-14
lines changed

config/notification.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ joinGroupApplication:
3131
reliabilityLevel: 1
3232
unreadCount: false
3333
offlinePush:
34-
enable: false
34+
enable: true
3535
title: joinGroupApplication title
3636
desc: joinGroupApplication desc
3737
ext: joinGroupApplication ext
@@ -51,7 +51,7 @@ groupApplicationAccepted:
5151
reliabilityLevel: 1
5252
unreadCount: false
5353
offlinePush:
54-
enable: false
54+
enable: true
5555
title: groupApplicationAccepted title
5656
desc: groupApplicationAccepted desc
5757
ext: groupApplicationAccepted ext
@@ -61,7 +61,7 @@ groupApplicationRejected:
6161
reliabilityLevel: 1
6262
unreadCount: false
6363
offlinePush:
64-
enable: false
64+
enable: true
6565
title: groupApplicationRejected title
6666
desc: groupApplicationRejected desc
6767
ext: groupApplicationRejected ext
@@ -198,7 +198,7 @@ friendApplicationAdded:
198198
reliabilityLevel: 1
199199
unreadCount: false
200200
offlinePush:
201-
enable: false
201+
enable: true
202202
title: Somebody applies to add you as a friend
203203
desc: Somebody applies to add you as a friend
204204
ext: Somebody applies to add you as a friend
@@ -228,7 +228,7 @@ friendAdded:
228228
reliabilityLevel: 1
229229
unreadCount: false
230230
offlinePush:
231-
enable: true
231+
enable: false
232232
title: We have become friends
233233
desc: We have become friends
234234
ext: We have become friends
@@ -238,7 +238,7 @@ friendDeleted:
238238
reliabilityLevel: 1
239239
unreadCount: false
240240
offlinePush:
241-
enable: true
241+
enable: false
242242
title: deleted a friend
243243
desc: deleted a friend
244244
ext: deleted a friend
@@ -248,7 +248,7 @@ friendRemarkSet:
248248
reliabilityLevel: 1
249249
unreadCount: false
250250
offlinePush:
251-
enable: true
251+
enable: false
252252
title: Your friend's profile has been changed
253253
desc: Your friend's profile has been changed
254254
ext: Your friend's profile has been changed
@@ -258,7 +258,7 @@ blackAdded:
258258
reliabilityLevel: 1
259259
unreadCount: false
260260
offlinePush:
261-
enable: true
261+
enable: false
262262
title: blocked a user
263263
desc: blocked a user
264264
ext: blocked a user
@@ -268,7 +268,7 @@ blackDeleted:
268268
reliabilityLevel: 1
269269
unreadCount: false
270270
offlinePush:
271-
enable: true
271+
enable: false
272272
title: Remove a blocked user
273273
desc: Remove a blocked user
274274
ext: Remove a blocked user
@@ -278,7 +278,7 @@ friendInfoUpdated:
278278
reliabilityLevel: 1
279279
unreadCount: false
280280
offlinePush:
281-
enable: true
281+
enable: false
282282
title: friend info updated
283283
desc: friend info updated
284284
ext: friend info updated
@@ -289,7 +289,7 @@ userInfoUpdated:
289289
reliabilityLevel: 1
290290
unreadCount: false
291291
offlinePush:
292-
enable: true
292+
enable: false
293293
title: userInfo updated
294294
desc: userInfo updated
295295
ext: userInfo updated
@@ -310,7 +310,7 @@ conversationChanged:
310310
reliabilityLevel: 1
311311
unreadCount: false
312312
offlinePush:
313-
enable: true
313+
enable: false
314314
title: conversation changed
315315
desc: conversation changed
316316
ext: conversation changed
@@ -320,7 +320,7 @@ conversationSetPrivate:
320320
reliabilityLevel: 1
321321
unreadCount: false
322322
offlinePush:
323-
enable: true
323+
enable: false
324324
title: burn after reading
325325
desc: burn after reading
326326
ext: burn after reading

internal/push/push_handler.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,10 @@ func (c *ConsumerHandler) shouldPushOffline(_ context.Context, msg *sdkws.MsgDat
187187
if !isOfflinePush {
188188
return false
189189
}
190-
if msg.ContentType == constant.SignalingNotification {
190+
switch msg.ContentType {
191+
case constant.RoomParticipantsConnectedNotification:
192+
return false
193+
case constant.RoomParticipantsDisconnectedNotification:
191194
return false
192195
}
193196
return true

0 commit comments

Comments
 (0)