Commit f5af2ef
committed
Fix: Correct max_output location in YAML profile templates
The YAML profile templates incorrectly show max_output under llm (llm.max_output),
but max_output belongs on Interpreter, not on the Llm class.
History:
- 20b8230: max_output was added as top-level in config.yaml
- 2400eab: Template changed to llm.max_output and parsing code removed (bug introduced)
- 861341c: Changed to nested YAML format but still under llm: (still wrong)
Evidence:
- max_output was originally top-level in 20b8230
- Llm class has no max_output attribute (unlike context_window, max_tokens)
- Code uses interpreter.max_output (core.py:420)
- Migration mapping doesn't include max_output (unlike other LLM settings)
The templates have been wrong since 2400eab, causing profiles with llm.max_output
to be silently ignored. Users saw the default (2800) instead of their configured
value.
Changes:
- Move max_output from llm: section to top-level in all YAML templates
(default.yaml, fast.yaml, snowpark.yml)
- Fix template comment in profiles.py used for new profile generation
This restores the original design where max_output is a top-level Interpreter
setting, matching the code structure.1 parent 0d19f3a commit f5af2ef
File tree
4 files changed
+13
-9
lines changed- interpreter/terminal_interface/profiles
- defaults
4 files changed
+13
-9
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | | - | |
| 36 | + | |
38 | 37 | | |
39 | 38 | | |
40 | 39 | | |
| |||
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
46 | | - | |
| 45 | + | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
| |||
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
55 | | - | |
56 | | - | |
| 54 | + | |
| 55 | + | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
63 | | - | |
| 62 | + | |
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
| |||
82 | 81 | | |
83 | 82 | | |
84 | 83 | | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
511 | 511 | | |
512 | 512 | | |
513 | 513 | | |
| 514 | + | |
| 515 | + | |
514 | 516 | | |
515 | 517 | | |
516 | 518 | | |
517 | 519 | | |
| 520 | + | |
518 | 521 | | |
519 | 522 | | |
520 | 523 | | |
| |||
523 | 526 | | |
524 | 527 | | |
525 | 528 | | |
526 | | - | |
527 | 529 | | |
528 | 530 | | |
529 | 531 | | |
| |||
0 commit comments