leading spaces on param key is a PITA to delete

[SyBernot]

we had some copy pasta that allowed a leading space in the param key outputting ' key'=>value which made things mad and it was impossible to remove the pair from the ONA interface. I'm guessing params shouldn't be able to have leading whitespace because YAML but I haven't had a chance to look into the spec.

I intend to fix it, just really pressed for time right now so this is my placeholder :)

[mattpascoe]

good call.. I have need to start updating this old module myself so hopefully I'll be fixing many other issues with it. :)

[SyBernot]

I have some other issues with this module

When deleting a host the classes params and environment associated with that host should be cleaned up too.

set primary keys on tables to ensure database sanity (we had a couple dupes in there, still not clear as to why
This alteration seems to be working
ALTER TABLE puppet_node_classes ADD PRIMARY KEY ( host_id , name ) ;
ALTER TABLE puppet_node_environments ADD PRIMARY KEY ( host_id ) ;
ALTER TABLE puppet_node_parameters ADD PRIMARY KEY ( host_id , name , value ) ;