Merge pull request #46 from openpatch/copilot/add-delete-button-student

feat: add delete student action to edit sheet

Author: mikebarkmin

assets/translations/de.json

@@ -69,6 +69,7 @@
   "confirm_archive_group_body": "Die Gruppe verschwindet aus der aktiven Liste, alle Daten bleiben erhalten.",
   "confirm_delete": "{name} löschen?",
   "confirm_delete_group_body": "Schüler:innen, Noten, Listen und verknüpfte Notizen dieser Gruppe werden gelöscht.",
+  "confirm_delete_student_body": "Alle Noten, Anwesenheiten, Materialien, Hausaufgaben, Notizen und Listeneinträge dieser Schüler:in werden gelöscht.",
   "confirm_passphrase": "Passphrase bestätigen",
   "create_database": "Bibliothek erstellen",
   "create_another_database": "Weitere Bibliothek erstellen",

assets/translations/en.json

@@ -69,6 +69,7 @@
   "confirm_archive_group_body": "The group will leave the active list, but its data stays available.",
   "confirm_delete": "Delete {name}?",
   "confirm_delete_group_body": "Students, grades, lists, and linked notes in this group will be deleted.",
+  "confirm_delete_student_body": "All grades, attendance, material, homework, notes, and list entries for this student will be deleted.",
   "confirm_passphrase": "Confirm passphrase",
   "create_database": "Create library",
   "create_another_database": "Create another library",

lib/features/students/student_detail_screen.dart

@@ -187,14 +187,30 @@ class StudentDetailScreen extends ConsumerWidget {
     WidgetRef ref,
     Student student,
   ) async {
+    var deleted = false;
     final result = await showStudentFormSheet(
       context: context,
       initialFirstName: student.firstName,
       initialLastName: student.lastName,
       initialOriginNote: student.originNote,
       initialAvatarJson: student.avatarJson,
       title: 'edit'.tr(),
+      onDelete: () async {
+        await ref
+            .read(studentRepositoryProvider)
+            .deleteStudent(student.id);
+        deleted = true;
+      },
     );
+    if (deleted) {
+      if (!context.mounted) return;
+      if (context.canPop()) {
+        context.pop();
+      } else {
+        context.go('/groups/${student.groupId}');
+      }
+      return;
+    }
     if (result == null) {
       return;
     }

lib/features/students/student_form.dart

@@ -5,6 +5,7 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 import '../../core/database/app_database.dart';
 import '../../core/providers/app_providers.dart';
 import '../../shared/utils/formatting.dart';
+import '../../shared/widgets/confirm_dialog.dart';
 import '../../shared/widgets/student_avatar.dart';
 import '../avatar/avatar_editor_sheet.dart';
 import 'student_draft.dart';
@@ -18,6 +19,7 @@ Future<StudentFormResult?> showStudentFormSheet({
   String? initialOriginNote,
   String? initialAvatarJson,
   String? title,
+  Future<void> Function()? onDelete,
 }) {
   return showModalBottomSheet<StudentFormResult>(
     context: context,
@@ -30,6 +32,7 @@ Future<StudentFormResult?> showStudentFormSheet({
       initialOriginNote: initialOriginNote,
       initialAvatarJson: initialAvatarJson,
       title: title,
+      onDelete: onDelete,
     ),
   );
 }
@@ -41,13 +44,15 @@ class _StudentFormSheet extends ConsumerStatefulWidget {
     this.initialOriginNote,
     this.initialAvatarJson,
     this.title,
+    this.onDelete,
   });
 
   final String? initialFirstName;
   final String? initialLastName;
   final String? initialOriginNote;
   final String? initialAvatarJson;
   final String? title;
+  final Future<void> Function()? onDelete;
 
   @override
   ConsumerState<_StudentFormSheet> createState() => _StudentFormSheetState();
@@ -165,8 +170,18 @@ class _StudentFormSheetState extends ConsumerState<_StudentFormSheet> {
               ),
               const SizedBox(height: 24),
               Row(
-                mainAxisAlignment: MainAxisAlignment.end,
                 children: [
+                  if (widget.onDelete != null) ...[
+                    TextButton(
+                      onPressed: _delete,
+                      style: TextButton.styleFrom(
+                        foregroundColor:
+                            Theme.of(context).colorScheme.error,
+                      ),
+                      child: Text('delete'.tr()),
+                    ),
+                  ],
+                  const Spacer(),
                   TextButton(
                     onPressed: () => Navigator.of(context).pop(),
                     child: Text('cancel'.tr()),
@@ -222,4 +237,27 @@ class _StudentFormSheetState extends ConsumerState<_StudentFormSheet> {
       avatarJson: _avatarJson,
     ));
   }
+
+  Future<void> _delete() async {
+    final confirmed = await showConfirmDialog(
+      context: context,
+      title: 'confirm_delete'.tr(
+        namedArgs: {
+          'name': studentDisplayName(
+            firstName: _firstNameController.text.trim(),
+            lastName: _lastNameController.text.trim(),
+          ),
+        },
+      ),
+      body: 'confirm_delete_student_body'.tr(),
+    );
+    if (!confirmed || !mounted) {
+      return;
+    }
+    await widget.onDelete!();
+    if (!mounted) {
+      return;
+    }
+    Navigator.of(context).pop();
+  }
 }