Refine error messages and remove redundant logging

Signed-off-by: shuangli-z <[email protected]>

Author: shuangli-z

common/src/main/java/org/opensearch/ml/common/indexInsight/FieldDescriptionTask.java

@@ -52,11 +52,14 @@ public void runTask(String tenantId, ActionListener<IndexInsight> listener) {
                     client,
                     tenantId,
                     ActionListener
-                        .wrap(agentId -> { batchProcessFields(statisticalContentMap, agentId, tenantId, listener); }, listener::onFailure)
+                        .wrap(
+                            agentId -> { batchProcessFields(statisticalContentMap, agentId, tenantId, listener); },
+                            e -> handleError("Failed to get agent ID from ML config", e, tenantId, listener)
+                        )
                 );
-            }, e -> handleError("Failed to get statistical content for index {}", e, tenantId, listener)));
+            }, e -> handleError("Failed to get statistical content for index: {}", e, tenantId, listener)));
         } catch (Exception e) {
-            handleError("Failed to execute field description task for index {}", e, tenantId, listener);
+            handleError("Failed to execute field description task for index: {}", e, tenantId, listener);
         }
     }
 
@@ -170,7 +173,7 @@ private void batchProcessFields(
             saveResult("", tenantId, ActionListener.wrap(insight -> {
                 log.info("Empty field description completed for: {}", sourceIndex);
                 listener.onResponse(insight);
-            }, e -> handleError("Failed to save empty field description result for index {}", e, tenantId, listener)));
+            }, e -> handleError("Failed to save empty field description result for index: {}", e, tenantId, listener)));
             return;
         }
 
@@ -195,13 +198,12 @@ private void batchProcessFields(
                 saveResult(gson.toJson(resultsMap), tenantId, ActionListener.wrap(insight -> {
                     log.info("Field description completed for: {}", sourceIndex);
                     listener.onResponse(insight);
-                }, e -> handleError("Failed to save field description result for index {}", e, tenantId, listener)));
+                }, e -> handleError("Failed to save field description result for index: {}", e, tenantId, listener)));
             } else {
-                handleError("Batch processing failed for index {}", new Exception("Batch processing failed"), tenantId, listener);
+                handleError("Batch processing failed for index: {}", new Exception("Batch processing failed"), tenantId, listener);
             }
         } catch (InterruptedException e) {
-            log.error("Batch processing interrupted for index: {}", sourceIndex);
-            handleError("Batch processing interrupted for index {}", e, tenantId, listener);
+            handleError("Batch processing interrupted for index: {}", e, tenantId, listener);
         }
     }
 

common/src/main/java/org/opensearch/ml/common/indexInsight/LogRelatedIndexCheckTask.java

@@ -92,11 +92,15 @@ public void runTask(String tenantId, ActionListener<IndexInsight> listener) {
                 getAgentIdToRun(
                     client,
                     tenantId,
-                    ActionListener.wrap(agentId -> performLogAnalysis(agentId, tenantId, listener), listener::onFailure)
+                    ActionListener
+                        .wrap(
+                            agentId -> performLogAnalysis(agentId, tenantId, listener),
+                            e -> handleError("Failed to get agent ID from ML config", e, tenantId, listener)
+                        )
                 );
             }, listener::onFailure));
         } catch (Exception e) {
-            handleError("Failed log related check for {}", e, tenantId, listener);
+            handleError("Failed log related check for index: {}", e, tenantId, listener);
         }
     }
 
@@ -136,13 +140,13 @@ private void performLogAnalysis(String agentId, String tenantId, ActionListener<
             try {
                 Map<String, Object> parsed = parseCheckResponse(response);
                 saveResult(MAPPER.writeValueAsString(parsed), tenantId, ActionListener.wrap(insight -> {
-                    log.info("Log related check completed for index {}", sourceIndex);
+                    log.info("Log related check completed for index: {}", sourceIndex);
                     listener.onResponse(insight);
-                }, e -> handleError("Failed to save log related check result for index {}", e, tenantId, listener)));
+                }, e -> handleError("Failed to save log related check result for index: {}", e, tenantId, listener)));
             } catch (Exception e) {
-                handleError("Error parsing response of log related check for {}", e, tenantId, listener);
+                handleError("Error parsing response of log related check for index: {}", e, tenantId, listener);
             }
-        }, e -> handleError("Failed to call LLM for log related check: {}", e, tenantId, listener)));
+        }, e -> handleError("Failed to call LLM for log related check for index: {}", e, tenantId, listener)));
     }
 
     private Map<String, Object> parseCheckResponse(String resp) {

common/src/main/java/org/opensearch/ml/common/indexInsight/StatisticalDataTask.java

@@ -101,7 +101,7 @@ public void runTask(String tenantId, ActionListener<IndexInsight> listener, bool
         try {
             collectStatisticalData(tenantId, shouldStore, listener);
         } catch (Exception e) {
-            handleError("Failed to execute statistical data task for index {}", e, tenantId, listener, shouldStore);
+            handleError("Failed to execute statistical data task for index: {}", e, tenantId, listener, shouldStore);
         }
     }
 
@@ -364,7 +364,7 @@ private Map<String, Object> parseSearchResult(
                         } catch (Exception e) {
                             log
                                 .error(
-                                    "Failed to parse aggregation result from DSL in statistical index insight for index name: {}",
+                                    "Failed to parse aggregation result from DSL in statistical index insight for index: {}",
                                     sourceIndex,
                                     e
                                 );