File tree Expand file tree Collapse file tree 3 files changed +15
-2
lines changed
Expand file tree Collapse file tree 3 files changed +15
-2
lines changed Original file line number Diff line number Diff line change @@ -97,10 +97,13 @@ struct Azure {
9797 // Immutable.
9898 NetworkSecurityGroupResourceID String
9999
100+ // This is renamed to 'required_operators_authentication'.
101+ // It brings concerns of; what if one of the operators stop being required anymore all the time?
102+ // How do people see the design considering the future evolutions concerns?
100103 // Defines how the operators of the cluster authenticate to Azure.
101104 // Required during creation.
102105 // Immutable.
103- OperatorsAuthentication AzureOperatorsAuthentication
106+ RequiredOperatorsAuthentication AzureOperatorsAuthentication
104107
105108 // NodesOutboundConnectivity defines how the network outbound
106109 // configuration of the Cluster's Node Pool's Nodes is performed.
Original file line number Diff line number Diff line change 1+ struct ClusterImageRegistry {
2+ ControlPlaneIdentity AzureControlPlaneManagedIdentity
3+ DataPlaneIdentity AzureDataPlaneManagedIdentity
4+ }
Original file line number Diff line number Diff line change @@ -247,5 +247,11 @@ class Cluster {
247247 RegistryConfig ClusterRegistryConfig
248248
249249 // OpenShift Cluster Capabilities configuration
250- Capabilities ClusterCapabilities
250+ // Commented because it'll be removed from the API as par the proposal in the DDR
251+ // Capabilities ClusterCapabilities
252+
253+ // At the moment it is top level at the cluster's spec.
254+ // We could move it to the .Azure field as it contains Azure specific things.
255+ // This is the one point we want to solve
256+ ImageRegistry ClusterImageRegistry
251257}
You can’t perform that action at this time.
0 commit comments