-
Notifications
You must be signed in to change notification settings - Fork 666
[release-4.20] OCPBUGS-65793: OpenShift Console can only show user name instead of full name as the display name #15743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s the display name (openshift#15522) * fix: Update CoreState type to include userResource for k8s API integration * feat: Add userResource management to core actions and reducer * feat: Introduce useUser hook for centralized user data management * refactor: Replace direct user data fetching with centralized useUser hook in telemetry and masthead components * test: auto generated the unit tests for useUser hook to validate user data retrieval and dispatch behavior * feat: Enhance useUser hook to provide robust display name handling with fallbacks and add corresponding unit tests * fix: apply the review feedback * Apply suggestions from code review Co-authored-by: logonoff <[email protected]> * feat: run i18n * feat: Add UserKind type import * Apply suggestions from code review Co-authored-by: logonoff <[email protected]> * Update frontend/public/locales/en/public.json Co-authored-by: logonoff <[email protected]> * Update frontend/packages/console-dynamic-plugin-sdk/src/app/core/actions/core.ts Co-authored-by: logonoff <[email protected]> * feat: Import UserKind type in core actions * refactor: Update GetUserResource type to use UserKind for improved type safety * test: Update useUser.spec.ts to mock setUserResource and correct displayName expectation * test: fixing the failing CI issue --------- Co-authored-by: logonoff <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@Leo6Leo: This pull request references Jira Issue OCPBUGS-65793, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@Leo6Leo: This pull request references Jira Issue OCPBUGS-65793, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@Leo6Leo: This pull request references Jira Issue OCPBUGS-65793, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Checked on cluster launched against the pr, login with openid connect idp user, the full name is shown as expected. |
|
@yanpzhan: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…ield tests by mocking useTelemetry hook
|
Fixing the failing test, no core code is modified, therefore retag the |
|
@Leo6Leo: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Getting the labels: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishagarwal278, Leo6Leo, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
|
@Leo6Leo: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Leo6Leo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
883425d
into
openshift:release-4.20
|
@Leo6Leo: Jira Issue Verification Checks: Jira Issue OCPBUGS-65793 Jira Issue OCPBUGS-65793 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Leo6Leo: #15743 failed to apply on top of branch "release-4.19": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in accepted release 4.20.0-0.nightly-2025-11-27-212931 |
This is a manual backport for #15522