Introduce common controller

To remove duplicate code across the test-operator controllers, this
patch introduces a common controller. This change should make
fixing controller bugs easier and prepare the test-operator for new
resource addition, if it is needed in the future.

Assisted-by: Claude AI

Author: kstrenkova

api/v1beta1/tempest_types.go

@@ -522,3 +522,8 @@ func (instance Tempest) RbacNamespace() string {
 func (instance Tempest) RbacResourceName() string {
 	return instance.Name
 }
+
+// GetConditions - return the conditions from the status
+func (instance *Tempest) GetConditions() *condition.Conditions {
+	return &instance.Status.Conditions
+}

controllers/ansibletest_controller.go

@@ -206,7 +206,7 @@ func (r *AnsibleTestReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 
 	// Create a new pod
 	mountCerts := r.CheckSecretExists(ctx, instance, "combined-ca-bundle")
-	podName := r.GetPodName(instance, nextWorkflowStep)
+	podName := GetPodName(instance, nextWorkflowStep)
 	envVars := r.PrepareAnsibleEnv(instance)
 	logsPVCName := r.GetPVCLogsName(instance, 0)
 	containerImage, err := r.GetContainerImage(ctx, instance)

controllers/common.go

@@ -300,7 +300,6 @@ func (r *Reconciler) GetContainerImage(
 // GetPodName returns the name of the pod for the given instance and workflow step
 func (r *Reconciler) GetPodName(instance interface{}, stepNum int) string {
 	v := reflect.ValueOf(instance)
-
 	name := GetStringField(v, "Name")
 	spec, err := SafetyCheck(v, "Spec")
 	if err != nil {
@@ -415,7 +414,7 @@ func (r *Reconciler) GetScheme() *runtime.Scheme {
 }
 
 // GetDefaultInt returns the string representation of an integer value with optional default value
-func (r *Reconciler) GetDefaultInt(variable int64, defaultValue ...string) string {
+func GetDefaultInt(variable int64, defaultValue ...string) string {
 	if variable != 0 {
 		return strconv.FormatInt(variable, 10)
 	} else if len(defaultValue) > 0 {
@@ -520,7 +519,7 @@ func (r *Reconciler) ReleaseLock(ctx context.Context, instance client.Object) (b
 // PodExists checks if a pod exists for the given instance and workflow step
 func (r *Reconciler) PodExists(ctx context.Context, instance client.Object, workflowStepNum int) bool {
 	pod := &corev1.Pod{}
-	podName := r.GetPodName(instance, workflowStepNum)
+	podName := GetPodName(instance, workflowStepNum)
 	objectKey := client.ObjectKey{Namespace: instance.GetNamespace(), Name: podName}
 	err := r.Client.Get(ctx, objectKey, pod)
 	if err != nil && k8s_errors.IsNotFound(err) {