Skip to content

Commit 9741f46

Browse files
adding missing rds parameters and fixing some old bugs (#471)
adding missing rds parameters and fixing some old bugs Reviewed-by: Anton Sidelnikov
1 parent 8f20b1b commit 9741f46

4 files changed

Lines changed: 40 additions & 7 deletions

File tree

otcextensions/sdk/rds/v3/_proxy.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,18 @@ def datastores(self, database_name):
6262

6363
# ======= Flavors =======
6464

65-
def flavors(self, datastore_name, version_name):
66-
"""List flavors of given datastore_name and datastore_version
65+
def flavors(self, datastore_name, **params):
66+
"""List flavors of given datastore_name and other optional parameters
6767
6868
:param datastore_name: datastore_name
6969
:param version_name: version_name
70+
:param spec_code: spec_code
7071
7172
:returns: A generator of flavor objects.
7273
"""
7374
return self._list(_flavor.Flavor,
7475
datastore_name=datastore_name,
75-
version_name=version_name)
76+
**params)
7677

7778
# ======= Instance =======
7879

otcextensions/sdk/rds/v3/flavor.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ class Flavor(resource.Resource):
1919

2020
# capabilities
2121
allow_list = True
22-
_query_mapping = resource.QueryParameters('version_name')
22+
_query_mapping = resource.QueryParameters(
23+
'version_name', 'spec_code')
2324

2425
datastore_name = resource.URI('datastore_name')
2526
#: Instance Mode (single/ha/replica)
@@ -37,3 +38,15 @@ class Flavor(resource.Resource):
3738
#: Amount of VCPU's
3839
#: *Type: str*
3940
vcpus = resource.Body('vcpus')
41+
#: Group type
42+
#: *Type: str*
43+
group_type = resource.Body('group_type')
44+
#: Supported Versions
45+
#: *Type:list*
46+
version_name = resource.Body('version_name', type=list)
47+
#: Availability Zone Status
48+
#: *Type: dict*
49+
az_status = resource.Body('az_status', type=dict)
50+
#: Availability Zone Description
51+
#: *Type: dict*
52+
az_desc = resource.Body('az_desc', type=dict)

otcextensions/tests/functional/sdk/auto_scaling/v1/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class TestAs(base.BaseFunctionalTest):
3030
AS_CONFIG = None
3131
AS_INSTANCE = None
3232
MAX_INST_NUMBER = 1
33-
IMAGE_NAME = "Standard_Debian_10_latest"
33+
IMAGE_NAME = "Standard_Debian_11_latest"
3434
DISK_SIZE = 4
3535
KP_NAME = None
3636
AS_GROUP_NAME = None

otcextensions/tests/unit/sdk/rds/v3/test_flavor.py

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,21 @@
1717
"vcpus": "1",
1818
"ram": 2,
1919
"spec_code": "rds.mysql.c2.medium.ha",
20-
"instance_mode": "ha"
20+
"instance_mode": "ha",
21+
"group_type": "normal",
22+
"version_name": [
23+
"8.0"
24+
],
25+
"az_status": {
26+
"eu-de-02": "normal",
27+
"eu-de-01": "normal",
28+
"eu-de-03": "normal"
29+
},
30+
"az_desc": {
31+
"eu-de-02": "eu-de-02",
32+
"eu-de-01": "eu-de-01",
33+
"eu-de-03": "eu-de-03"
34+
}
2135
}
2236

2337

@@ -37,7 +51,8 @@ def test_basic(self):
3751
self.assertFalse(sot.allow_commit)
3852
self.assertDictEqual({'limit': 'limit',
3953
'marker': 'marker',
40-
'version_name': 'version_name'},
54+
'version_name': 'version_name',
55+
'spec_code': 'spec_code'},
4156
sot._query_mapping._mapping)
4257

4358
def test_make_it(self):
@@ -48,3 +63,7 @@ def test_make_it(self):
4863
self.assertEqual(EXAMPLE['vcpus'], sot.vcpus)
4964
self.assertEqual(EXAMPLE['ram'], sot.ram)
5065
self.assertEqual(EXAMPLE['instance_mode'], sot.instance_mode)
66+
self.assertEqual(EXAMPLE['group_type'], sot.group_type)
67+
self.assertEqual(EXAMPLE['version_name'], sot.version_name)
68+
self.assertEqual(EXAMPLE['az_status'], sot.az_status)
69+
self.assertEqual(EXAMPLE['az_desc'], sot.az_desc)

0 commit comments

Comments
 (0)