fix withspan handler nullable + example (#1377)

brettmc · web-flow · commit f74cbed0247f · 2024-09-07T08:51:46.000+10:00
- class is nullable for pre hooks
- add phpt tests for withspan and its interaction with auto root span
diff --git a/Instrumentation/WithSpanHandler.php b/Instrumentation/WithSpanHandler.php
@@ -18,7 +18,7 @@ class WithSpanHandler
     /**
      * @psalm-suppress ArgumentTypeCoercion
      */
-    public static function pre(mixed $target, array $params, string $class, string $function, ?string $filename, ?int $lineno, ?array $span_args = [], ?array $attributes = []): void
+    public static function pre(mixed $target, array $params, ?string $class, string $function, ?string $filename, ?int $lineno, ?array $span_args = [], ?array $attributes = []): void
     {
         static $instrumentation;
         $instrumentation ??= new CachedInstrumentation(name: 'io.opentelemetry.php.with-span', schemaUrl: 'https://opentelemetry.io/schemas/1.25.0');

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ class WithSpanHandler`
`18`	`18`	`/**`
`19`	`19`	`* @psalm-suppress ArgumentTypeCoercion`
`20`	`20`	`*/`
`21`		`- public static function pre(mixed $target, array $params, string $class, string $function, ?string $filename, ?int $lineno, ?array $span_args = [], ?array $attributes = []): void`
	`21`	`+ public static function pre(mixed $target, array $params, ?string $class, string $function, ?string $filename, ?int $lineno, ?array $span_args = [], ?array $attributes = []): void`
`22`	`22`	`{`
`23`	`23`	`static $instrumentation;`
`24`	`24`	`$instrumentation ??= new CachedInstrumentation(name: 'io.opentelemetry.php.with-span', schemaUrl: 'https://opentelemetry.io/schemas/1.25.0');`