Check fix

Author: atobiszei

src/llm/io_processing/qwen3coder/qwen3coder_tool_parser.cpp

@@ -127,7 +127,7 @@ static const ParametersTypeMap_t parseToolSchema(const std::string& functionName
     return result;
 }
 
-// helper function to escape \n
+// helper function to escape \n, "
 static std::string escapeString(const std::string& input) {
     std::string output;
     output.reserve(input.size());
@@ -136,6 +136,9 @@ static std::string escapeString(const std::string& input) {
         case '\n':
             output += "\\n";
             break;
+        case '"':
+            output += "\\\"";
+            break;
         default:
             output += c;
         }
@@ -236,7 +239,9 @@ bool Qwen3CoderToolParserImpl::parseUntilStateChange(ToolCalls_t& toolCalls) {
         if (paramIt == this->toolsParametersTypeMap.end()) {
             SPDLOG_DEBUG("Tool schema not found for tool: {}, leaving parameter: {} as string", this->currentFunction.name, this->currentParameterName);
         } else {
-            parameterValue = escapeString(setCorrectValueType(parameterValue, this->currentParameterName, paramIt->second));
+            // we don't want to escape entry/exit " for string parameters
+            auto escaped = escapeString(parameterValue);
+            parameterValue =setCorrectValueType(escaped, this->currentParameterName, paramIt->second);
         }
         auto res = this->currentFunction.parameters.try_emplace(this->currentParameterName, parameterValue);
         if (!res.second)

src/test/llm/output_parsers/qwen3coder_output_parser_test.cpp

@@ -642,7 +642,7 @@ END_VAR
 
 END_FUNCTION</parameter>
 </function>
-</tool_call>)", ov::genai::GenerationFinishReason::NONE, R"({"delta":{"tool_calls":[{"index":5,"function":{"arguments":"{\"arg1\": \"FUNCTION FC_CreateJsonPayload : STRING\\nVAR_INPUT\\n    Value1 : REAL;\\n    Value2 : INT;\\n    Value3 : BOOL;\\n    Value4 : STRING(100);\\nEND_VAR\\nVAR_OUTPUT\\n    JsonPayload : STRING(1000);\\nEND_VAR\\nVAR\\n    TempStr : STRING(100);\\nEND_VAR\\n\\n    JsonPayload := '{';\\n    JsonPayload := JsonPayload + '\"value1\":' + REAL_TO_STRING(Value1, '', 2) + ',';\\n    JsonPayload := JsonPayload + '\"value2\":' + INT_TO_STRING(Value2) + ',';\\n    JsonPayload := JsonPayload + '\"value3\":' + BOOL_TO_STRING(Value3) + ',';\\n    JsonPayload := JsonPayload + '\"value4\":\"' + Value4 + '\"';\\n    JsonPayload := JsonPayload + '}';\\n\\nEND_FUNCTION\"}"}}]}})"},
+</tool_call>)", ov::genai::GenerationFinishReason::NONE, R"({"delta":{"tool_calls":[{"index":5,"function":{"arguments":"{\"arg1\": \"FUNCTION FC_CreateJsonPayload : STRING\\nVAR_INPUT\\n    Value1 : REAL;\\n    Value2 : INT;\\n    Value3 : BOOL;\\n    Value4 : STRING(100);\\nEND_VAR\\nVAR_OUTPUT\\n    JsonPayload : STRING(1000);\\nEND_VAR\\nVAR\\n    TempStr : STRING(100);\\nEND_VAR\\n\\n    JsonPayload := '{';\\n    JsonPayload := JsonPayload + '\\\"value1\\\":' + REAL_TO_STRING(Value1, '', 2) + ',';\\n    JsonPayload := JsonPayload + '\\\"value2\\\":' + INT_TO_STRING(Value2) + ',';\\n    JsonPayload := JsonPayload + '\\\"value3\\\":' + BOOL_TO_STRING(Value3) + ',';\\n    JsonPayload := JsonPayload + '\\\"value4\\\":\\\"' + Value4 + '\\\"';\\n    JsonPayload := JsonPayload + '}';\\n\\nEND_FUNCTION\"}"}}]}})"},
         {"<tool_call><function=string_tool><parameter=arg1>", ov::genai::GenerationFinishReason::NONE, R"({"delta":{"tool_calls":[{"id":"XXXXXXXXX","type":"function","index":6,"function":{"name":"string_tool"}}]}})"},
         {R"(
 if __name__ == "__main__":
@@ -651,7 +651,7 @@ if __name__ == "__main__":
     addresses["Arya"] = "Winterfell"
     for name, address in addresses.items():
         print(f'{name} lives at {address}')
-</parameter></function></tool_call>)", ov::genai::GenerationFinishReason::NONE, R"({"delta":{"tool_calls":[{"index":6,"function":{"arguments":"{\"arg1\": \"if __name__ == \"__main__\":\\n    addresses = {}\\n    addresses[\"Hodor\"] = \"\"\"The door\"\"\"\\n    addresses[\"Arya\"] = \"Winterfell\"\\n    for name, address in addresses.items():\\n        print(f'{name} lives at {address}')\"}"}}]}})"}
+</parameter></function></tool_call>)", ov::genai::GenerationFinishReason::NONE, R"({"delta":{"tool_calls":[{"index":6,"function":{"arguments":"{\"arg1\": \"if __name__ == \\\"__main__\\\":\\n    addresses = {}\\n    addresses[\\\"Hodor\\\"] = \\\"\\\"\\\"The door\\\"\\\"\\\"\\n    addresses[\\\"Arya\\\"] = \\\"Winterfell\\\"\\n    for name, address in addresses.items():\\n        print(f'{name} lives at {address}')\"}"}}]}})"}
     };
     for (const auto& [chunk, finishReason, expectedDelta] : chunkToDeltaVec) {
         i++;