fix lint

Author: Avaneesh-axiom

benchmarks/execute/benches/execute.rs

@@ -22,9 +22,7 @@ use openvm_continuations::{
     verifier::{common::types::VmVerifierPvs, leaf::types::LeafVmVerifierInput},
     SC,
 };
-use openvm_ecc_circuit::{
-    EccCpuProverExt, EccExtension, EccExtensionExecutor, EccExtensionPeriphery,
-};
+use openvm_ecc_circuit::{EccCpuProverExt, EccExtension, EccExtensionExecutor};
 use openvm_ecc_transpiler::EccTranspilerExtension;
 use openvm_keccak256_circuit::{Keccak256, Keccak256CpuProverExt, Keccak256Executor};
 use openvm_keccak256_transpiler::Keccak256TranspilerExtension;
@@ -181,11 +179,7 @@ where
             inventory,
         )?;
         VmProverExtension::<E, _, _>::extend_prover(&AlgebraCpuProverExt, &config.fp2, inventory)?;
-        VmProverExtension::<E, _, _>::extend_prover(
-            &EccCpuProverExt,
-            &config.weierstrass,
-            inventory,
-        )?;
+        VmProverExtension::<E, _, _>::extend_prover(&EccCpuProverExt, &config.ecc, inventory)?;
         VmProverExtension::<E, _, _>::extend_prover(&PairingProverExt, &config.pairing, inventory)?;
         Ok(chip_complex)
     }

extensions/ecc/circuit/src/ecc_extension.rs

@@ -560,9 +560,11 @@ lazy_static! {
     ));
 }
 // little-endian
-const P256_A: [u8; 32] = hex!("fcffffffffffffffffffffff00000000000000000000000001000000ffffffff");
+pub const P256_A: [u8; 32] =
+    hex!("fcffffffffffffffffffffff00000000000000000000000001000000ffffffff");
 // little-endian
-const P256_B: [u8; 32] = hex!("4b60d2273e3cce3bf6b053ccb0061d65bc86987655bdebb3e7933aaad835c65a");
+pub const P256_B: [u8; 32] =
+    hex!("4b60d2273e3cce3bf6b053ccb0061d65bc86987655bdebb3e7933aaad835c65a");
 
 pub const SECP256K1_ECC_STRUCT_NAME: &str = "Secp256k1Point";
 pub const P256_ECC_STRUCT_NAME: &str = "P256Point";

extensions/ecc/circuit/src/edwards_chip/add.rs

@@ -96,6 +96,7 @@ fn gen_base_expr(
     (expr, local_opcode_idx)
 }
 
+#[allow(clippy::too_many_arguments)]
 pub fn get_te_add_air<const BLOCKS: usize, const BLOCK_SIZE: usize>(
     exec_bridge: ExecutionBridge,
     mem_bridge: MemoryBridge,
@@ -287,7 +288,6 @@ impl<F: PrimeField32, const BLOCKS: usize, const BLOCK_SIZE: usize> Executor<F>
                     { TeCurveType::ED25519 as u8 },
                     false,
                 >),
-                _ => panic!("Unsupported curve type"),
             }
         } else if is_setup {
             Ok(execute_e12_impl::<_, _, BLOCKS, BLOCK_SIZE, { u8::MAX }, true>)
@@ -337,7 +337,6 @@ impl<F: PrimeField32, const BLOCKS: usize, const BLOCK_SIZE: usize> MeteredExecu
                 (false, TeCurveType::ED25519) => {
                     Ok(execute_e2_impl::<_, _, BLOCKS, BLOCK_SIZE, { TeCurveType::ED25519 as u8 }>)
                 }
-                _ => panic!("Unsupported curve type"),
             }
         } else if is_setup {
             Ok(execute_e2_setup_impl::<_, _, BLOCKS, BLOCK_SIZE, { u8::MAX }>)
@@ -390,7 +389,7 @@ unsafe fn execute_e2_setup_impl<
             std::mem::size_of::<TeAddPreCompute>(),
         )
     };
-    execute_e12_impl::<_, _, BLOCKS, BLOCK_SIZE, CURVE_TYPE, true>(&pre_compute, vm_state);
+    execute_e12_impl::<_, _, BLOCKS, BLOCK_SIZE, CURVE_TYPE, true>(pre_compute, vm_state);
 }
 
 unsafe fn execute_e12_impl<

extensions/ecc/circuit/src/edwards_chip/tests.rs

@@ -1,21 +1,21 @@
 use std::{str::FromStr, sync::Arc};
 
 use num_bigint::BigUint;
-use num_traits::{FromPrimitive, Num, Zero};
+use num_traits::FromPrimitive;
 use openvm_circuit::arch::{
     testing::{TestChipHarness, VmChipTestBuilder, BITWISE_OP_LOOKUP_BUS},
     MatrixRecordArena,
 };
 use openvm_circuit_primitives::{
-    bigint::utils::{big_uint_to_limbs, secp256k1_coord_prime, secp256r1_coord_prime},
+    bigint::utils::big_uint_to_limbs,
     bitwise_op_lookup::{
         BitwiseOperationLookupAir, BitwiseOperationLookupBus, BitwiseOperationLookupChip,
         SharedBitwiseOperationLookupChip,
     },
 };
-use openvm_ecc_transpiler::{Rv32EdwardsOpcode, Rv32WeierstrassOpcode};
+use openvm_ecc_transpiler::Rv32EdwardsOpcode;
 use openvm_instructions::{riscv::RV32_CELL_BITS, LocalOpcode};
-use openvm_mod_circuit_builder::{test_utils::biguint_to_limbs, ExprBuilderConfig, FieldExpr};
+use openvm_mod_circuit_builder::{test_utils::biguint_to_limbs, ExprBuilderConfig};
 use openvm_rv32_adapters::rv32_write_heap_default;
 use openvm_stark_backend::p3_field::FieldAlgebra;
 use openvm_stark_sdk::p3_baby_bear::BabyBear;
@@ -172,10 +172,6 @@ fn test_add() {
         num_limbs: NUM_LIMBS,
         limb_bits: LIMB_BITS,
     };
-    let bitwise_bus = BitwiseOperationLookupBus::new(BITWISE_OP_LOOKUP_BUS);
-    let bitwise_chip = Arc::new(BitwiseOperationLookupChip::<RV32_CELL_BITS>::new(
-        bitwise_bus,
-    ));
 
     let (mut harness, bitwise) = create_test_chip(
         &tester,

guest-libs/p256/tests/lib.rs

@@ -97,8 +97,7 @@ mod guest_tests {
             system::SystemChipInventory,
         };
         use openvm_ecc_circuit::{
-            CurveConfig, EccExtension, EccExtensionExecutor, Rv32EccConfig, Rv32EccConfigExecutor,
-            Rv32EccCpuBuilder, SwCurveCoeffs,
+            CurveConfig, Rv32EccConfig, Rv32EccConfigExecutor, Rv32EccCpuBuilder, SwCurveCoeffs,
         };
         use openvm_sha256_circuit::{Sha256, Sha256Executor, Sha2CpuProverExt};
         use openvm_stark_backend::{