Skip to content

[didcomm-mediator-credo] Allow specifying existing secret for values not generated by the chart #77

Description

@i5okie

The two values, pickup-connection-json and firebase-apps, are not populated by the Helm chart during installation (https://github.com/openwallet-foundation/helm-charts/blob/main/charts/didcomm-mediator-credo/templates/secrets.yaml#L19-L20). This allows these values to be unintentionally reset to their default values when upgrading the Helm chart. I believe a better approach would be to update the chart to require users to manually create the secret and specify the name of the secret containing these two parameters in the Values file.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions