-
Notifications
You must be signed in to change notification settings - Fork 125
Description
First of all, thank you so much for all your hard work. You've created some amazing research, and I enjoy reading all of your blog posts, it's taught me a lot about animating with code.
In regards to the code, within controller.cpp, Line 1633 onwards, we check the need to perform a transition, based on the difference between the new features and the current features within projector_evaluate, however, the transition_cost is set to 0 and not modified between the initialisation at the start of the function and the check, as well as this, it is never overwritten, as the projector_evaluate is only ever called once with no parameter for transition_cost.
As well as this, within my own tests, this difference is always 0 for all features, leading transition to never fire, and it leads me to consider whether there can be any optimisations made by removing these redundant checks, or whether there is an error in the implementation?
I'm currently struggle with the large changes in direction that this feature was seeming created to resolve, so any extra information would be greatly appreciated.
Jack