Espruinotools / the Espruino PICO_R1_3 any general issues ?

[SimonGAndrews]

Hi @gfwilliams Im working on the espruino test harness as discussed some time ago in https://github.com/orgs/espruino/discussions/7659.
Im not wanting to promise too much, but making some progress with the harness and test working with the ESP32C3 quite well. Im looking at the Espruino boards also working in the modified test harness and have an MDBT42Q on the way. Im testing my developed harness on the PICO at the moment. Can I ask a general question? Are there known issues with the Espruinotools cli utilising the PICO board. I seem to be running into issues with basic espruinotools cli invocation, around it not seeing prompts etc from the board. I realise the PICO works fine in the webIDE.

One specific is when invoking

espruino --port /dev/ttyACM0 --board PICO_R1_3 --config RESET_BEFORE_SEND=true --config ENV_ON_CONNECT=true /tmp/pico_test.js

i get

TypeError: Cannot read properties of undefined (reading 'length')
    at writeChunk (.../core/serial.js:248:27)

not asking for a fix, just the general question, Thanks

[gfwilliams]

That's great, thanks for looking into this.

Ok, that's interesting! I can reproduce here too. I guess it's from https://github.com/espruino/EspruinoTools/blob/master/core/serial.js#L248 where write has been called with undefined data (possibly it gets called again after the data has been emptied out of the buffer) but I'd love to know how.

I wasn't aware of any issues, and I've been using the IDE with STM32 quite a lot recently - however I haven't been using the CLI much and we did recently change the way serial.js works, so it uses the same Connection object as uart.js so it's possible some bugs crept in at that point.

I'm pretty busy the next few days but I'll try and pick this up when I get back

[gfwilliams]

Just to add you could try a version of espruinotools from before that change went in... I had 0.1.54 on this laptop from before and that worked ok

[SimonGAndrews]

Thanks @gfwilliams .
No hurry from my part . I got the MDBT42Q concected over UART yesterday and its not got all the issue symptoms im seeing on the PICO , and moving on to an EspruinoWIFI and ESP32 boards I already have. So plenty for me to do . Im happy to proceed with testing a new test harness and summarise any board specific issues after . On holiday over the next couple of weeks also. In due course ill share more on what im doing but would like to get something proven and documented first.
I will try the previous version of Espruino tools also (but maybe till after hols) .

On that specific issue , it does seem to help if in serial.js around line 248 as you id'd , write chunk just updates progress and returns if txItem or txItem.data is undefined. But I really dont understand what im looking at there so would have to leave that for another. !

[gfwilliams]

Sorry for the delay - I just fixed this! espruino/EspruinoTools@bfc1b5d

Not made an NPM release yet but it's in GitHub at least. Thanks for the report - it could have affected a bunch of stuff (it's in uart.js as well, with Bangle.js app loader uses)

[SimonGAndrews]

Thanks @gfwilliams I have tried out the changes you comitted and Im no longer seeing the

TypeError: Cannot read properties of undefined (reading 'length')

Also I see you fixed the type error on the port. - really good stuff thanks

I cant quite follow it but i see there is improved logging with a debug level , looks usefull.
Thanks Again, Simon