tuned phpstan & fixed possible logging bug

Author: Oliver Stark

CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.3.2] - 2018-04-06
+### Fixed
+- Delegate Exception::getMessage() instead of Exception to error log
+
+### Changed
+- Increased phpstan analyse level from 1 to 5
+- Excluded expected errors from phpstan
+- Use `Craft::debug()` instead of deprecated `Craft::trace()`
+
 ## [1.3.1] - 2018-04-05
 ### Changed
 - Changed version constraint to `craftcms/cms: ^3.0.0`
@@ -37,7 +46,6 @@ All notable changes to this project will be documented in this file.
 
 
 ## [1.1.0] - 2017-10-13
-
 ### Changed
 - Added AFTER_PUSH listener
 - Removed custom Queue class

composer.json

@@ -2,7 +2,7 @@
   "name": "ostark/craft-async-queue",
   "description": "A queue handler that moves queue execution to a non-blocking background process",
   "type": "craft-plugin",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "keywords": [
     "craft",
     "cms",
@@ -40,7 +40,7 @@
     "phpstan/phpstan": "^0.9.2"
   },
   "scripts": {
-    "ps": "vendor/bin/phpstan analyse src --level=1 -c phpstan.neon",
+    "ps": "vendor/bin/phpstan analyse src --level=5 -c phpstan.neon",
     "stan": "@ps"
   }
 }

phpstan.neon

@@ -4,3 +4,4 @@ parameters:
 		- %currentWorkingDirectory%/vendor/craftcms/cms/src/Craft.php
 	ignoreErrors:
 		- '#Constant CRAFT_BASE_PATH not found#'
+		- '#Method ostark\AsyncQueue\\Plugin::getHandler() should return ostark\\AsyncQueue\\QueueHandler but returns object|null#'

src/Plugin.php

@@ -89,6 +89,7 @@ function (ActionEvent $event) {
      */
     public function getHandler(): QueueHandler
     {
+
         return $this->get('async_handler');
     }
 

src/QueueHandler.php

@@ -28,10 +28,10 @@ public function startBackgroundProcess()
         try {
             $process->run();
         } catch (\Exception $e) {
-            Craft::error($e, __METHOD__);
+            Craft::error($e->getMessage(), __METHOD__);
         }
 
-        Craft::trace(
+        Craft::debug(
             Craft::t(
                 'async-queue',
                 'Job status: {status}. Exit code: {code}', ['status' => $process->getStatus(), 'code' => $process->getExitCodeText()]