Merge pull request #157 from mcg-web/fix-handling-invariant-violation-exceptions

Fix error handler to white list `GraphQL\Error\InvariantViolation`

Author: mcg-web

Error/ErrorHandler.php

@@ -12,6 +12,7 @@
 namespace Overblog\GraphQLBundle\Error;
 
 use GraphQL\Error\Error as GraphQLError;
+use GraphQL\Error\InvariantViolation;
 use GraphQL\Executor\ExecutionResult;
 use Psr\Log\LoggerInterface;
 use Psr\Log\LogLevel;
@@ -83,8 +84,8 @@ protected function treatExceptions(array $errors, $throwRawException)
         foreach ($errors as $error) {
             $rawException = $this->convertException($error->getPrevious());
 
-            // Parse error or user error
-            if (null === $rawException) {
+            // raw GraphQL Error or InvariantViolation exception
+            if (null === $rawException || $rawException instanceof InvariantViolation) {
                 $treatedExceptions['errors'][] = $error;
                 continue;
             }

Tests/Error/ErrorHandlerTest.php

@@ -12,6 +12,7 @@
 namespace Overblog\GraphQLBundle\Tests\Error;
 
 use GraphQL\Error\Error as GraphQLError;
+use GraphQL\Error\InvariantViolation;
 use GraphQL\Executor\ExecutionResult;
 use Overblog\GraphQLBundle\Error\ErrorHandler;
 use Overblog\GraphQLBundle\Error\UserError;
@@ -38,6 +39,7 @@ public function testMaskErrorWithThrowExceptionSetToFalse()
                 new GraphQLError('Error with wrapped user error', null, null, null, null, new UserError('My User Error')),
                 new GraphQLError('', null, null, null, null, new UserErrors(['My User Error 1', 'My User Error 2', new UserError('My User Error 3')])),
                 new GraphQLError('Error with wrapped user warning', null, null, null, null, new UserWarning('My User Warning')),
+                new GraphQLError('Invalid value!', null, null, null, null, new InvariantViolation('Invalid value!')),
             ]
         );
 
@@ -63,6 +65,9 @@ public function testMaskErrorWithThrowExceptionSetToFalse()
                 [
                     'message' => 'My User Error 3',
                 ],
+                [
+                    'message' => 'Invalid value!',
+                ],
             ],
             'extensions' => [
                 'warnings' => [