Skip to content

Commit bf65a21

Browse files
committed
feat: use separate storage for storing live dependencies
The files generated by this plugin should be stored in a separate storage and bucket. This will make it easier and safer to remove all the live dependencies if need be.
1 parent c7fe9fd commit bf65a21

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- [Feature] Use separate storage for storing live dependencies. (by @mlabeeb03)
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
STORAGES["livedeps"] = {
2+
"BACKEND": "storages.backends.s3boto3.S3Boto3Storage",
3+
"OPTIONS": {
4+
"bucket_name": "livedeps",
5+
},
6+
}

tutorlivedeps/plugin.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ def build_live_dependencies(context: Context) -> t.Iterable[tuple[str, str]]:
8686
archive_path = shutil.make_archive(base[:-4], format="zip", root_dir=DEPS_DIR)
8787
8888
with open(archive_path, "rb") as f:
89-
# TODO Use a separate storage for live dependencies
90-
storages["default"].save(DEPS_KEY, File(f))
89+
storages["livedeps"].save(DEPS_KEY, File(f))
9190
'
9291
"""
9392

tutorlivedeps/templates/livedeps/build/monitor_livedeps.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
DEPS_ZIP_PATH = DEPS_DIR[:-4] + DEPS_KEY
1010
TRIGGER_FILE = "/openedx/live-dependencies/uwsgi_trigger"
1111

12-
# TODO Use a separate storage for live dependencies
13-
storage = storages["default"]
12+
storage = storages["livedeps"]
1413

1514
while True:
1615
if storage.exists(DEPS_KEY):

tutorlivedeps/templates/livedeps/build/update_livedeps.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
DEPS_KEY = "deps.zip"
99
DEPS_ZIP_PATH = DEPS_DIR[:-4] + DEPS_KEY
1010

11-
# TODO Use a separate storage for live dependencies
12-
storage = storages["default"]
11+
storage = storages["livedeps"]
1312

1413
if storage.exists(DEPS_KEY):
1514
if os.path.exists(DEPS_DIR):

0 commit comments

Comments
 (0)