Skip to content

Commit f8b861c

Browse files
authored
enhancement(web): show select-all checkbox label in tile view (#12640)
feat(web): show select-all checkbox label in tile view Make the select-all checkbox label visible in the tile view to match the list view and make the checkbox's purpose clear.
1 parent 8b675b2 commit f8b861c

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
Enhancement: Show the select-all checkbox label in tile view
2+
3+
The label of the select-all checkbox in the resource tiles view is now
4+
visible, improving the user experience by making it clear what the
5+
checkbox is for.
6+
7+
https://github.com/owncloud/ocis/pull/12640

web/packages/web-pkg/src/components/FilesList/ResourceTiles.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
class="oc-ml-s"
88
size="large"
99
:label="selectAllCheckboxLabel"
10-
:label-hidden="true"
10+
:label-hidden="false"
1111
:disabled="resources.length === disabledResourceIds.length"
1212
:model-value="areAllResourcesSelected"
1313
@click.stop="toggleSelectionAll"

web/packages/web-pkg/tests/unit/components/FilesList/__snapshots__/ResourceTiles.spec.ts.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
exports[`ResourceTiles component > renders a footer slot 1`] = `
44
"<div id="tiles-view" class="oc-px-m oc-pt-l">
5-
<div class="oc-flex oc-flex-middle oc-mb-m oc-pb-s oc-tiles-controls"><span class="oc-ml-s"><input id="tiles-view-select-all" type="checkbox" name="checkbox" class="oc-checkbox oc-rounded oc-checkbox-l" disabled="" aria-label="Select all"> <!--v-if--></span>
5+
<div class="oc-flex oc-flex-middle oc-mb-m oc-pb-s oc-tiles-controls"><span class="oc-ml-s"><input id="tiles-view-select-all" type="checkbox" name="checkbox" class="oc-checkbox oc-rounded oc-checkbox-l" disabled=""> <label for="tiles-view-select-all" class="">Select all</label></span>
66
<!--v-if-->
77
</div>
88
<ul class="oc-list oc-my-rm oc-mx-rm oc-tiles"> </ul>
@@ -13,7 +13,7 @@ exports[`ResourceTiles component > renders a footer slot 1`] = `
1313
1414
exports[`ResourceTiles component > renders an array of spaces correctly 1`] = `
1515
"<div id="tiles-view" class="oc-px-m oc-pt-l">
16-
<div class="oc-flex oc-flex-middle oc-mb-m oc-pb-s oc-tiles-controls"><span class="oc-ml-s"><input id="tiles-view-select-all" type="checkbox" name="checkbox" class="oc-checkbox oc-rounded oc-checkbox-l" aria-label="Select all"> <!--v-if--></span>
16+
<div class="oc-flex oc-flex-middle oc-mb-m oc-pb-s oc-tiles-controls"><span class="oc-ml-s"><input id="tiles-view-select-all" type="checkbox" name="checkbox" class="oc-checkbox oc-rounded oc-checkbox-l"> <label for="tiles-view-select-all" class="oc-cursor-pointer">Select all</label></span>
1717
<!--v-if-->
1818
</div>
1919
<ul class="oc-list oc-my-rm oc-mx-rm oc-tiles">

0 commit comments

Comments
 (0)