Skip to content

Commit 792ae31

Browse files
committed
test(estree, allocator): use default to create ESTreeSerializers (#13211)
Pure refactor of tests related to `ESTree`. `ESTreeSerializer` implements `Default`, so create `ESTreeSerializer`s with `default`, instead of explicitly passing `ranges: false`.
1 parent ade2ccb commit 792ae31

File tree

7 files changed

+21
-21
lines changed

7 files changed

+21
-21
lines changed

crates/oxc_allocator/src/boxed.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ mod test {
243243
let allocator = Allocator::default();
244244
let b = Box::new_in("x", &allocator);
245245

246-
let mut serializer = CompactTSSerializer::new(false);
246+
let mut serializer = CompactTSSerializer::default();
247247
b.serialize(&mut serializer);
248248
let s = serializer.into_string();
249249
assert_eq!(s, r#""x""#);

crates/oxc_allocator/src/vec.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ mod test {
311311
let mut v = Vec::new_in(&allocator);
312312
v.push("x");
313313

314-
let mut serializer = CompactTSSerializer::new(false);
314+
let mut serializer = CompactTSSerializer::default();
315315
v.serialize(&mut serializer);
316316
let s = serializer.into_string();
317317
assert_eq!(s, r#"["x"]"#);

crates/oxc_estree/src/serialize/blanket.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ mod tests {
5757
let cases = [(&"foo", r#""foo""#), (&&"bar", r#""bar""#)];
5858

5959
for (input, output) in cases {
60-
let mut serializer = CompactTSSerializer::new(false);
60+
let mut serializer = CompactTSSerializer::default();
6161
input.serialize(&mut serializer);
6262
let s = serializer.into_string();
6363
assert_eq!(&s, output);
@@ -69,7 +69,7 @@ mod tests {
6969
let cases = [(&mut "foo", r#""foo""#), (&mut &mut "bar", r#""bar""#)];
7070

7171
for (input, output) in cases {
72-
let mut serializer = CompactTSSerializer::new(false);
72+
let mut serializer = CompactTSSerializer::default();
7373
input.serialize(&mut serializer);
7474
let s = serializer.into_string();
7575
assert_eq!(&s, output);
@@ -81,7 +81,7 @@ mod tests {
8181
let cases = [(None, "null"), (Some(123.0f64), "123")];
8282

8383
for (input, output) in cases {
84-
let mut serializer = CompactTSSerializer::new(false);
84+
let mut serializer = CompactTSSerializer::default();
8585
input.serialize(&mut serializer);
8686
let s = serializer.into_string();
8787
assert_eq!(&s, output);
@@ -94,7 +94,7 @@ mod tests {
9494
[(Cow::Borrowed("foo"), r#""foo""#), (Cow::Owned("bar".to_string()), r#""bar""#)];
9595

9696
for (input, output) in cases {
97-
let mut serializer = CompactTSSerializer::new(false);
97+
let mut serializer = CompactTSSerializer::default();
9898
input.serialize(&mut serializer);
9999
let s = serializer.into_string();
100100
assert_eq!(&s, output);

crates/oxc_estree/src/serialize/primitives.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ mod tests {
7171

7272
fn run_test<T: ESTree>(cases: &[(T, &str)]) {
7373
for (input, output) in cases {
74-
let mut serializer = CompactTSSerializer::new(false);
74+
let mut serializer = CompactTSSerializer::default();
7575
input.serialize(&mut serializer);
7676
let s = serializer.into_string();
7777
assert_eq!(&s, output);

crates/oxc_estree/src/serialize/sequences.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,12 @@ mod tests {
121121

122122
let foo = Foo { none: &[], one: &["one"], two: ["two one", "two two"] };
123123

124-
let mut serializer = CompactTSSerializer::new(false);
124+
let mut serializer = CompactTSSerializer::default();
125125
foo.serialize(&mut serializer);
126126
let s = serializer.into_string();
127127
assert_eq!(&s, r#"{"none":[],"one":["one"],"two":["two one","two two"]}"#);
128128

129-
let mut serializer = PrettyTSSerializer::new(false);
129+
let mut serializer = PrettyTSSerializer::default();
130130
foo.serialize(&mut serializer);
131131
let s = serializer.into_string();
132132
assert_eq!(

crates/oxc_estree/src/serialize/strings.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ mod tests {
467467
];
468468

469469
for (input, output) in cases {
470-
let mut serializer = CompactTSSerializer::new(false);
470+
let mut serializer = CompactTSSerializer::default();
471471
input.serialize(&mut serializer);
472472
let s = serializer.into_string();
473473
assert_eq!(&s, output);
@@ -479,7 +479,7 @@ mod tests {
479479
let cases = [(String::new(), r#""""#), ("foobar".to_string(), r#""foobar""#)];
480480

481481
for (input, output) in cases {
482-
let mut serializer = CompactTSSerializer::new(false);
482+
let mut serializer = CompactTSSerializer::default();
483483
input.to_string().serialize(&mut serializer);
484484
let s = serializer.into_string();
485485
assert_eq!(&s, output);
@@ -491,7 +491,7 @@ mod tests {
491491
let cases = [("", r#""""#), ("a", r#""a""#), ("abc", r#""abc""#)];
492492

493493
for (input, output) in cases {
494-
let mut serializer = CompactTSSerializer::new(false);
494+
let mut serializer = CompactTSSerializer::default();
495495
JsonSafeString(input).serialize(&mut serializer);
496496
let s = serializer.into_string();
497497
assert_eq!(&s, output);
@@ -514,7 +514,7 @@ mod tests {
514514
];
515515

516516
for (input, output) in cases {
517-
let mut serializer = CompactTSSerializer::new(false);
517+
let mut serializer = CompactTSSerializer::default();
518518
LoneSurrogatesString(input).serialize(&mut serializer);
519519
let s = serializer.into_string();
520520
assert_eq!(&s, output);

crates/oxc_estree/src/serialize/structs.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -405,15 +405,15 @@ mod tests {
405405
maybe_not_bar: None,
406406
};
407407

408-
let mut serializer = CompactTSSerializer::new(false);
408+
let mut serializer = CompactTSSerializer::default();
409409
foo.serialize(&mut serializer);
410410
let s = serializer.into_string();
411411
assert_eq!(
412412
&s,
413413
r#"{"n":123,"u":12345,"bar":{"yes":"yup","no":"nope"},"empty":{},"hello":"hi!","maybe_bar":{"yes":"hell yeah!","no":"not a chance in a million, mate"},"maybe_not_bar":null}"#
414414
);
415415

416-
let mut serializer = PrettyTSSerializer::new(false);
416+
let mut serializer = PrettyTSSerializer::default();
417417
foo.serialize(&mut serializer);
418418
let s = serializer.into_string();
419419
assert_eq!(
@@ -494,15 +494,15 @@ mod tests {
494494
outer2: "out2",
495495
};
496496

497-
let mut serializer = CompactTSSerializer::new(false);
497+
let mut serializer = CompactTSSerializer::default();
498498
outer.serialize(&mut serializer);
499499
let s = serializer.into_string();
500500
assert_eq!(
501501
&s,
502502
r#"{"outer1":"out1","inner1":"in1","innermost1":"inin1","innermost2":"inin2","inner2":"in2","outer2":"out2"}"#
503503
);
504504

505-
let mut serializer = PrettyTSSerializer::new(false);
505+
let mut serializer = PrettyTSSerializer::default();
506506
outer.serialize(&mut serializer);
507507
let s = serializer.into_string();
508508
assert_eq!(
@@ -540,12 +540,12 @@ mod tests {
540540

541541
let foo = Foo { js: 1, ts: 2, js_only: 3, more_js: 4 };
542542

543-
let mut serializer = CompactTSSerializer::new(false);
543+
let mut serializer = CompactTSSerializer::default();
544544
foo.serialize(&mut serializer);
545545
let s = serializer.into_string();
546546
assert_eq!(&s, r#"{"js":1,"ts":2,"moreJs":4}"#);
547547

548-
let mut serializer = PrettyTSSerializer::new(false);
548+
let mut serializer = PrettyTSSerializer::default();
549549
foo.serialize(&mut serializer);
550550
let s = serializer.into_string();
551551
assert_eq!(
@@ -557,12 +557,12 @@ mod tests {
557557
}"#
558558
);
559559

560-
let mut serializer = CompactJSSerializer::new(false);
560+
let mut serializer = CompactJSSerializer::default();
561561
foo.serialize(&mut serializer);
562562
let s = serializer.into_string();
563563
assert_eq!(&s, r#"{"js":1,"jsOnly":3,"moreJs":4}"#);
564564

565-
let mut serializer = PrettyJSSerializer::new(false);
565+
let mut serializer = PrettyJSSerializer::default();
566566
foo.serialize(&mut serializer);
567567
let s = serializer.into_string();
568568
assert_eq!(

0 commit comments

Comments
 (0)