fix(linter): parse ignorePatterns with gitignore syntax

Author: Sysix

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/.oxlintrc.json

@@ -0,0 +1,5 @@
+{
+  "ignorePatterns": [
+    "ignored_dir"
+  ]
+}

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/ignored_dir/index.ts

@@ -0,0 +1 @@
+debugger;

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/with_nested/.oxlintrc.json

@@ -0,0 +1,5 @@
+{
+  "ignorePatterns": [
+    "ignored_dir"
+  ]
+}

apps/oxlint/fixtures/ignore_pattern_non_glob_syntax/with_nested/ignored_dir/index.ts

@@ -0,0 +1 @@
+debugger;

apps/oxlint/src/lint.rs

@@ -667,6 +667,16 @@ mod test {
             .test_and_snapshot_multiple(&[args1, args2]);
     }
 
+    #[test]
+    // https://github.com/oxc-project/oxc/issues/13204
+    fn ignore_pattern_non_glob_syntax() {
+        let args1 = &[];
+        let args2 = &["."];
+        Tester::new()
+            .with_cwd("fixtures/ignore_pattern_non_glob_syntax".into())
+            .test_and_snapshot_multiple(&[args1, args2]);
+    }
+
     #[test]
     fn filter_allow_all() {
         let args = &["-A", "all", "fixtures/linter"];

apps/oxlint/src/snapshots/fixtures__ignore_pattern_non_glob_syntax_ [email protected]

@@ -0,0 +1,22 @@
+---
+source: apps/oxlint/src/tester.rs
+---
+########## 
+arguments: 
+working directory: fixtures/ignore_pattern_non_glob_syntax
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 0 files using 1 threads.
+----------
+CLI result: LintSucceeded
+----------
+
+########## 
+arguments: .
+working directory: fixtures/ignore_pattern_non_glob_syntax
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 0 files using 1 threads.
+----------
+CLI result: LintSucceeded
+----------

crates/oxc_linter/src/config/config_store.rs

@@ -330,9 +330,9 @@ impl ConfigStore {
     }
 
     pub fn should_ignore(&self, path: &Path) -> bool {
-        self.get_related_config(path)
-            .ignore_patterns()
-            .is_some_and(|ignore_patterns| ignore_patterns.matched(path, false).is_ignore())
+        self.get_related_config(path).ignore_patterns().is_some_and(|ignore_patterns| {
+            ignore_patterns.matched_path_or_any_parents(path, false).is_ignore()
+        })
     }
 
     // NOTE: This function is not crate visible because it is used in `oxlint` as well to resolve configs

crates/oxc_linter/src/config/mod.rs

@@ -14,14 +14,14 @@ pub use config_builder::{ConfigBuilderError, ConfigStoreBuilder};
 pub use config_store::{Config, ConfigStore, ResolvedLinterState};
 pub use env::OxlintEnv;
 pub use globals::{GlobalValue, OxlintGlobals};
-use ignore::overrides::OverrideBuilder;
+use ignore::gitignore::{Gitignore, GitignoreBuilder};
 pub use overrides::OxlintOverrides;
 pub use oxlintrc::Oxlintrc;
 pub use plugins::{BuiltinLintPlugins, LintPlugins};
 pub use rules::{ESLintRule, OxlintRules};
 pub use settings::{OxlintSettings, jsdoc::JSDocPluginSettings};
 
-pub type ResolvedIgnorePatterns = ignore::overrides::Override;
+pub type ResolvedIgnorePatterns = Gitignore;
 
 #[derive(Debug, Default, Clone)]
 pub struct LintConfig {
@@ -61,15 +61,13 @@ impl LintConfig {
         // expect that every oxlint config file with "ignorePatterns" provides its config path with parent.
         // for the default config the path is empty, but there should be no ignore patterns
         let oxlint_wd = config_path.parent()?.to_path_buf();
-
-        let mut builder = OverrideBuilder::new(&oxlint_wd);
+        let mut gitignore_builder = GitignoreBuilder::new(&oxlint_wd);
 
         for pattern in ignore_patterns {
-            let pattern = format!("!{pattern}");
-            builder.add(&pattern).unwrap();
+            gitignore_builder.add_line(None, pattern).unwrap();
         }
 
-        builder.build().ok()
+        gitignore_builder.build().ok()
     }
 }