make clients with strict-connect option explicitly connect to provided snode.#2174
Open
majestrate wants to merge 1 commit intooxen-io:devfrom
Open
make clients with strict-connect option explicitly connect to provided snode.#2174majestrate wants to merge 1 commit intooxen-io:devfrom
majestrate wants to merge 1 commit intooxen-io:devfrom
Conversation
majestrate
force-pushed
the
strict-connect-issue-2169-fix-2023-05-10
branch
from
3b9c8d0 to
7960597
Compare
…nnect out to snodes provided. * create new component for selecting edge snodes as client (llarp::consensus::EdgeSelector) * require llarp::AbstractRouter own a llarp::consensus::EdgeSelector * make outbound_session_maker.cpp use llarp::consensus::EdgeSelector owned by llarp::AbstractRouter
majestrate
force-pushed
the
strict-connect-issue-2169-fix-2023-05-10
branch
from
7960597 to
dea8ad2
Compare
Contributor
Author
|
this and #2164 should address the wire protocol regression introduced in 0.9.11, getting this merged would be a great thing to add to a point release before flipping the network into full on quic tls/1.3 |
Contributor
Author
|
@tewinget it may help in refactoring the existing path builder code to decompose the existing path selection code to have similar kinds of hop selectors as this PR does e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make lokinet client with strict-connect option provided explicitly connect out to snodes provided. before it was just randomly chugging through peer selection until it found one we explicitly pinned. this rarely works.
fixes #2169