Bump to 2024 edition (#1799)

I got tired of my editor's LSP complaining about `gen`, and decided to
update everything to Rust 2024.

This was mostly mechanical renaming of `gen` → `generation`, Clippy
fixes, and `rustfmt`.

`VolumeConstructionRequest` has to have a `#[serde(rename = "gen")]`
annotation, because it's been stored on disk.

Author: mkeeter

agent-antagonist/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "agent-antagonist"
 version = "0.1.0"
-edition = "2021"
+edition = "2024"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 

agent-antagonist/src/main.rs

@@ -1,5 +1,5 @@
-use anyhow::bail;
 use anyhow::Result;
+use anyhow::bail;
 use clap::Parser;
 use crucible_common::build_logger;
 use futures::StreamExt;
@@ -11,14 +11,14 @@ use slog::{info, warn};
 use std::net::SocketAddr;
 use std::process::Command;
 use std::sync::{
-    atomic::{AtomicBool, Ordering},
     Arc,
+    atomic::{AtomicBool, Ordering},
 };
 use uuid::Uuid;
 
 use crucible_agent_client::{
-    types::{CreateRegion, RegionId, State as RegionState},
     Client as CrucibleAgentClient,
+    types::{CreateRegion, RegionId, State as RegionState},
 };
 
 #[derive(Debug, Parser)]

agent-client/Cargo.toml

@@ -2,7 +2,7 @@
 name = "crucible-agent-client"
 version = "0.0.1"
 license = "MPL-2.0"
-edition = "2021"
+edition = "2024"
 
 [dependencies]
 anyhow.workspace = true

agent/Cargo.toml

@@ -2,7 +2,7 @@
 name = "crucible-agent"
 version = "0.0.1"
 license = "MPL-2.0"
-edition = "2021"
+edition = "2024"
 
 [dependencies]
 anyhow.workspace = true

agent/src/datafile.rs

@@ -1,19 +1,19 @@
 // Copyright 2021 Oxide Computer Company
 
-use anyhow::{anyhow, bail, Result};
+use anyhow::{Result, anyhow, bail};
 use crucible_agent_types::{region::*, snapshot::*};
 use crucible_common::write_json;
 use serde::{Deserialize, Serialize};
-use slog::{crit, error, info, Logger};
+use slog::{Logger, crit, error, info};
 use std::collections::BTreeMap;
 use std::net::SocketAddr;
 use std::path::Path;
 use std::path::PathBuf;
 use std::sync::{Arc, Condvar, Mutex, MutexGuard};
 
+use crate::ZFSDataset;
 use crate::resource::Resource;
 use crate::snapshot_interface::SnapshotInterface;
-use crate::ZFSDataset;
 
 pub struct DataFile {
     log: Logger,
@@ -434,31 +434,29 @@ impl DataFile {
          */
         if let Some(running_snapshots) =
             inner.running_snapshots.get(&request.id)
+            && let Some(running_snapshot) = running_snapshots.get(&request.name)
         {
-            if let Some(running_snapshot) = running_snapshots.get(&request.name)
-            {
-                match running_snapshot.state {
-                    State::Requested | State::Created | State::Tombstoned => {
-                        bail!(
-                            "read-only downstairs running for region {} snapshot {}",
-                            request.id.0,
-                            request.name
-                        );
-                    }
+            match running_snapshot.state {
+                State::Requested | State::Created | State::Tombstoned => {
+                    bail!(
+                        "read-only downstairs running for region {} snapshot {}",
+                        request.id.0,
+                        request.name
+                    );
+                }
 
-                    State::Destroyed => {
-                        // ok to delete
-                    }
+                State::Destroyed => {
+                    // ok to delete
+                }
 
-                    State::Failed => {
-                        // Something has set the running snapshot to state
-                        // failed, so we can't delete this snapshot.
-                        bail!(
-                            "read-only downstairs state set to failed for region {} snapshot {}",
-                            request.id.0,
-                            request.name
-                        );
-                    }
+                State::Failed => {
+                    // Something has set the running snapshot to state
+                    // failed, so we can't delete this snapshot.
+                    bail!(
+                        "read-only downstairs state set to failed for region {} snapshot {}",
+                        request.id.0,
+                        request.name
+                    );
                 }
             }
         }
@@ -489,7 +487,10 @@ impl DataFile {
                             // This is a bug: according to the agent's datafile,
                             // the region exists, but according to zfs list, it
                             // does not
-                            bail!("Agent thinks region {} exists but zfs list does not! {e}", request.id.0);
+                            bail!(
+                                "Agent thinks region {} exists but zfs list does not! {e}",
+                                request.id.0
+                            );
                         }
 
                         State::Failed => {
@@ -503,7 +504,11 @@ impl DataFile {
                     }
                 } else {
                     // In here, the region never existed!
-                    bail!("Inside region {} snapshot {} delete, region never existed! {e}", request.id.0, request.name);
+                    bail!(
+                        "Inside region {} snapshot {} delete, region never existed! {e}",
+                        request.id.0,
+                        request.name
+                    );
                 }
             }
         };
@@ -863,7 +868,7 @@ impl DataFile {
 
 #[cfg(test)]
 mod test {
-    use anyhow::{bail, Result};
+    use anyhow::{Result, bail};
     use chrono::{DateTime, TimeZone, Utc};
     use std::process::Command;
 
@@ -901,9 +906,8 @@ mod test {
             let cmd_stdout = String::from_utf8_lossy(&cmd.stdout);
 
             // Remove newline
-            let cmd_stdout = cmd_stdout.trim_end().to_string();
 
-            cmd_stdout
+            cmd_stdout.trim_end().to_string()
         };
 
         let _date = Utc.timestamp_opt(cmd_stdout.parse()?, 0).unwrap();

agent/src/main.rs

@@ -1,10 +1,10 @@
 // Copyright 2021 Oxide Computer Company
 
-use anyhow::{anyhow, bail, Result};
+use anyhow::{Result, anyhow, bail};
 use clap::Parser;
 use crucible_agent_types::smf::SmfProperty;
 use dropshot::{ConfigLogging, ConfigLoggingIfExists, ConfigLoggingLevel};
-use slog::{debug, error, info, o, Logger};
+use slog::{Logger, debug, error, info, o};
 use std::collections::HashSet;
 use std::net::SocketAddr;
 use std::path::{Path, PathBuf};
@@ -1195,7 +1195,7 @@ mod test {
     use crate::snapshot_interface::TestSnapshotInterface;
 
     use crucible_agent_types::{region::*, snapshot::*};
-    use slog::{o, Drain, Logger};
+    use slog::{Drain, Logger, o};
     use std::collections::BTreeMap;
     use tempfile::*;
     use uuid::Uuid;

agent/src/server.rs

@@ -1,14 +1,14 @@
 // Copyright 2024 Oxide Computer Company
 use super::datafile::DataFile;
-use anyhow::{anyhow, Result};
+use anyhow::{Result, anyhow};
 use crucible_agent_api::*;
 use crucible_agent_types::{region, snapshot};
 use dropshot::{
     ClientSpecifiesVersionInHeader, HandlerTaskMode, HttpError,
     HttpResponseDeleted, HttpResponseOk, Path as TypedPath, RequestContext,
     TypedBody, VersionPolicy,
 };
-use slog::{o, Logger};
+use slog::{Logger, o};
 use std::net::SocketAddr;
 use std::result::Result as SResult;
 use std::sync::Arc;

agent/src/snapshot_interface.rs

@@ -1,8 +1,8 @@
 // Copyright 2023 Oxide Computer Company
 
-use anyhow::{bail, Result};
+use anyhow::{Result, bail};
 use crucible_agent_types::snapshot::Snapshot;
-use slog::{error, info, Logger};
+use slog::{Logger, error, info};
 #[cfg(test)]
 use std::collections::HashSet;
 use std::process::Command;
@@ -113,9 +113,8 @@ impl SnapshotInterface for ZfsSnapshotInterface {
                 let cmd_stdout = String::from_utf8_lossy(&cmd.stdout);
 
                 // Remove newline
-                let cmd_stdout = cmd_stdout.trim_end().to_string();
 
-                cmd_stdout
+                cmd_stdout.trim_end().to_string()
             };
 
             if !cmd.status.success() {

cmon/Cargo.toml

@@ -2,7 +2,7 @@
 name = "cmon"
 version = "0.1.0"
 license = "MPL-2.0"
-edition = "2021"
+edition = "2024"
 
 [dependencies]
 clap.workspace = true

cmon/src/main.rs

@@ -6,7 +6,7 @@ use std::fmt;
 use std::io::{self, BufRead};
 use strum::IntoEnumIterator;
 use strum_macros::EnumIter;
-use tokio::time::{sleep, Duration};
+use tokio::time::{Duration, sleep};
 
 use crucible::DtraceInfo;