nexus: switch_port_settings_route_config integration tests

Author: sudomateo

nexus/tests/integration_tests/schema.rs

@@ -28,7 +28,9 @@ use similar_asserts;
 use slog::Logger;
 use slog_error_chain::InlineErrorChain;
 use std::collections::BTreeMap;
+use std::collections::HashMap;
 use std::net::IpAddr;
+use std::str::FromStr;
 use std::sync::Mutex;
 use tokio::time::Duration;
 use tokio::time::timeout;
@@ -2711,6 +2713,84 @@ fn after_164_0_0<'a>(ctx: &'a MigrationContext<'a>) -> BoxFuture<'a, ()> {
     })
 }
 
+const ROUTE_CONFIG_PORT_SETTINGS_ID_0: &str =
+    "1e700b64-79e0-4515-9771-bcc2391b6d4d";
+const ROUTE_CONFIG_PORT_SETTINGS_ID_1: &str =
+    "c6b015ff-1c98-474f-b9e9-dfc30546094f";
+const ROUTE_CONFIG_PORT_SETTINGS_ID_2: &str =
+    "8b777d9b-62a3-4c4d-b0b7-314315c2a7fc";
+const ROUTE_CONFIG_PORT_SETTINGS_ID_3: &str =
+    "7c675e89-74b1-45da-9577-cf75f028107a";
+const ROUTE_CONFIG_PORT_SETTINGS_ID_4: &str =
+    "e2413d63-9307-4918-b9c4-bce959c63042";
+
+// Insert records using the `local_pref` column before it's renamed and its
+// database type is changed from INT8 to INT2. The receiving Rust type is u8
+// so 2 records are outside the u8 range, 2 records are at the edge of the u8
+// range, and 1 record is within the u8 range.
+fn before_165_0_0<'a>(ctx: &'a MigrationContext<'a>) -> BoxFuture<'a, ()> {
+    Box::pin(async move {
+        ctx.client
+            .batch_execute(&format!("
+                INSERT INTO omicron.public.switch_port_settings_route_config
+                  (port_settings_id, interface_name, dst, gw, vid, local_pref)
+                VALUES
+                  (
+                    '{ROUTE_CONFIG_PORT_SETTINGS_ID_0}', 'phy0', '0.0.0.0/0', '0.0.0.0', NULL, -1
+                  ),
+                  (
+                    '{ROUTE_CONFIG_PORT_SETTINGS_ID_1}', 'phy0', '0.0.0.0/0', '0.0.0.0', NULL, 0
+                  ),
+                  (
+                    '{ROUTE_CONFIG_PORT_SETTINGS_ID_2}', 'phy0', '0.0.0.0/0', '0.0.0.0', NULL, 128
+                  ),
+                  (
+                    '{ROUTE_CONFIG_PORT_SETTINGS_ID_3}', 'phy0', '0.0.0.0/0', '0.0.0.0', NULL, 255
+                  ),
+                  (
+                    '{ROUTE_CONFIG_PORT_SETTINGS_ID_4}', 'phy0', '0.0.0.0/0', '0.0.0.0', NULL, 256
+                  );
+              "),
+            )
+            .await
+            .expect("failed to insert pre-migration rows for 165");
+    })
+}
+
+// Query the records using the new `rib_priority` column and assert that the
+// values were correctly clamped within the u8 range.
+fn after_165_0_0<'a>(ctx: &'a MigrationContext<'a>) -> BoxFuture<'a, ()> {
+    Box::pin(async move {
+        let rows = ctx
+            .client
+            .query(
+                "SELECT * FROM omicron.public.switch_port_settings_route_config;",
+                &[],
+            )
+            .await
+            .expect("failed to query post-migration switch_port_settings_route_config table");
+        assert_eq!(rows.len(), 5);
+
+        let records: HashMap<Uuid, i16> = HashMap::from([
+            (Uuid::from_str(ROUTE_CONFIG_PORT_SETTINGS_ID_0).unwrap(), 0),
+            (Uuid::from_str(ROUTE_CONFIG_PORT_SETTINGS_ID_1).unwrap(), 0),
+            (Uuid::from_str(ROUTE_CONFIG_PORT_SETTINGS_ID_2).unwrap(), 128),
+            (Uuid::from_str(ROUTE_CONFIG_PORT_SETTINGS_ID_3).unwrap(), 255),
+            (Uuid::from_str(ROUTE_CONFIG_PORT_SETTINGS_ID_4).unwrap(), 255),
+        ]);
+
+        for row in rows {
+            let port_settings_id = row.get::<&str, Uuid>("port_settings_id");
+            let rib_priority_got = row.get::<&str, i16>("rib_priority");
+
+            let rib_priority_want = records
+                .get(&port_settings_id)
+                .expect("unexpected port_settings_id value when querying switch_port_settings_route_config");
+            assert_eq!(rib_priority_got, *rib_priority_want);
+        }
+    })
+}
+
 // Lazily initializes all migration checks. The combination of Rust function
 // pointers and async makes defining a static table fairly painful, so we're
 // using lazy initialization instead.
@@ -2801,6 +2881,10 @@ fn get_migration_checks() -> BTreeMap<Version, DataMigrationFns> {
         Version::new(164, 0, 0),
         DataMigrationFns::new().before(before_164_0_0).after(after_164_0_0),
     );
+    map.insert(
+        Version::new(165, 0, 0),
+        DataMigrationFns::new().before(before_165_0_0).after(after_165_0_0),
+    );
 
     map
 }