When creating multiple links with `lldp_link_config` enabled, the API response does not show them both as enabled

[internet-diglett]

Potential bug identified discovered in oxidecomputer/terraform-provider-oxide#426 (comment)

It was reported that when creating two links with lldp enabled, the API nulls one of the configurations:

  "links": [
    {
      "port_settings_id": "698f4600-0f9d-48d0-ad8b-caf00e7b0e92",
      "link_name": "phy0",
      "mtu": 1500,
      "fec": null,
      "speed": "speed1_g",
      "autoneg": false,
      "lldp_link_config": null,
      "tx_eq_config": null
    },
    {
      "port_settings_id": "698f4600-0f9d-48d0-ad8b-caf00e7b0e92",
      "link_name": "phy1",
      "mtu": 1500,
      "fec": null,
      "speed": "speed10_g",
      "autoneg": false,
      "lldp_link_config": {
        "id": "42f34fbd-6556-4dff-ab4b-e387ed7a761a",
        "enabled": true,
        "link_name": "phy0",
        "link_description": null,
        "chassis_id": null,
        "system_name": null,
        "system_description": null,
        "management_ip": null
      },
      "tx_eq_config": null
    }
  ],

[sudomateo]

Here's what I did, irrespective of Terraform.

I have the following address lots as queried at /v1/system/networking/address-lot.

{
  "next_page": "eyJ2IjoidjEiLCJwYWdlX3N0YXJ0Ijp7InNvcnRfYnkiOiJuYW1lX2FzY2VuZGluZyIsImxhc3Rfc2VlbiI6ImluaXRpYWwtaW5mcmEifX0=",
  "items": [
    {
      "id": "8d2399d5-1e15-4543-9131-8ea2e1052360",
      "name": "example",
      "description": "example",
      "time_created": "2025-07-18T15:20:34.410995Z",
      "time_modified": "2025-07-18T15:20:34.410995Z",
      "kind": "infra"
    },
    {
      "id": "fc81531c-adb2-44a5-bc94-1cb5e74eca4d",
      "name": "initial-infra",
      "description": "initial infrastructure ip address lot",
      "time_created": "2025-07-18T15:06:52.868522Z",
      "time_modified": "2025-07-18T15:06:52.868522Z",
      "kind": "infra"
    }
  ]
}

Here's the blocks for that address lot as queried at /v1/system/networking/address-lot/example/blocks.

{
  "next_page": "eyJ2IjoidjEiLCJwYWdlX3N0YXJ0Ijp7InNvcnRfYnkiOiJpZF9hc2NlbmRpbmciLCJsYXN0X3NlZW4iOiI0NzBhMGUzOS03OGQwLTRlYWItODc0My0zZGUxMjNkMzQ3ZWUifX0=",
  "items": [
    {
      "id": "470a0e39-78d0-4eab-8743-3de123d347ee",
      "first_address": "10.85.0.22",
      "last_address": "10.85.0.33"
    }
  ]
}

I created the following switch port settings JSON request body.

{
  "name": "example",
  "description": "example",
  "port_config": {
    "geometry": "qsfp28x1"
  },
  "addresses": [
    {
      "link_name": "phy0",
      "addresses": [
        {
          "address": "10.85.0.22/32",
          "address_lot": "8d2399d5-1e15-4543-9131-8ea2e1052360"
        }
      ]
    },
    {
      "link_name": "phy1",
      "addresses": [
        {
          "address": "10.85.0.23/32",
          "address_lot": "8d2399d5-1e15-4543-9131-8ea2e1052360"
        }
      ]
    }
  ],
  "links": [
    {
      "link_name": "phy0",
      "autoneg": false,
      "mtu": 1500,
      "speed": "speed1_g",
      "lldp": {
        "enabled": true
      }
    },
    {
      "link_name": "phy1",
      "autoneg": false,
      "mtu": 1500,
      "speed": "speed1_g",
      "lldp": {
        "enabled": true
      }
    }
  ],
  "routes": [
    {
      "link_name": "phy0",
      "routes": [
        {
          "dst": "0.0.0.0/0",
          "gw": "0.0.0.0"
        }
      ]
    },
    {
      "link_name": "phy1",
      "routes": [
        {
          "dst": "0.0.0.0/0",
          "gw": "10.85.0.1"
        }
      ]
    }
  ]
}

I then created the switch port settings. Notice that the response body contains non-null links[].lldp_link_config attributes for both links.

> curl --request POST --header "Authorization: Bearer $OXIDE_TOKEN" --header "Content-Type: application/json" $OXIDE_HOST/v1/system/networking/switch-port-settings --data @body.json
{
  "id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
  "name": "example",
  "description": "example",
  "time_created": "2025-07-18T17:09:39.166649Z",
  "time_modified": "2025-07-18T17:09:39.166649Z",
  "groups": [],
  "port": {
    "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
    "geometry": "qsfp28x1"
  },
  "links": [
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "link_name": "phy0",
      "mtu": 1500,
      "fec": null,
      "speed": "speed1_g",
      "autoneg": false,
      "lldp_link_config": {
        "id": "61fcaeb3-187c-4982-8f3a-4f35770d5893",
        "enabled": true,
        "link_name": null,
        "link_description": null,
        "chassis_id": null,
        "system_name": null,
        "system_description": null,
        "management_ip": null
      },
      "tx_eq_config": null
    },
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "link_name": "phy1",
      "mtu": 1500,
      "fec": null,
      "speed": "speed1_g",
      "autoneg": false,
      "lldp_link_config": {
        "id": "67674142-51d8-46c0-b4cd-eafc54325397",
        "enabled": true,
        "link_name": null,
        "link_description": null,
        "chassis_id": null,
        "system_name": null,
        "system_description": null,
        "management_ip": null
      },
      "tx_eq_config": null
    }
  ],
  "interfaces": [],
  "vlan_interfaces": [],
  "routes": [
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "interface_name": "phy0",
      "dst": "0.0.0.0/0",
      "gw": "0.0.0.0",
      "vlan_id": null,
      "rib_priority": null
    },
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "interface_name": "phy1",
      "dst": "0.0.0.0/0",
      "gw": "10.85.0.1",
      "vlan_id": null,
      "rib_priority": null
    }
  ],
  "bgp_peers": [],
  "addresses": [
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "address_lot_id": "8d2399d5-1e15-4543-9131-8ea2e1052360",
      "address_lot_name": "example",
      "address_lot_block_id": "470a0e39-78d0-4eab-8743-3de123d347ee",
      "address": "10.85.0.22/32",
      "vlan_id": null,
      "interface_name": "phy0"
    },
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "address_lot_id": "8d2399d5-1e15-4543-9131-8ea2e1052360",
      "address_lot_name": "example",
      "address_lot_block_id": "470a0e39-78d0-4eab-8743-3de123d347ee",
      "address": "10.85.0.23/32",
      "vlan_id": null,
      "interface_name": "phy1"
    }
  ]
}

I then fetched the switch port settings at /v1/system/networking/switch-port-settings/example. Notice that the response body now contains a null links[].lldp_link_config attribute for one of the links.

{
  "id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
  "name": "example",
  "description": "example",
  "time_created": "2025-07-18T17:09:39.166649Z",
  "time_modified": "2025-07-18T17:09:39.166649Z",
  "groups": [],
  "port": {
    "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
    "geometry": "qsfp28x1"
  },
  "links": [
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "link_name": "phy0",
      "mtu": 1500,
      "fec": null,
      "speed": "speed1_g",
      "autoneg": false,
      "lldp_link_config": {
        "id": "61fcaeb3-187c-4982-8f3a-4f35770d5893",
        "enabled": true,
        "link_name": null,
        "link_description": null,
        "chassis_id": null,
        "system_name": null,
        "system_description": null,
        "management_ip": null
      },
      "tx_eq_config": null
    },
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "link_name": "phy1",
      "mtu": 1500,
      "fec": null,
      "speed": "speed1_g",
      "autoneg": false,
      "lldp_link_config": null,
      "tx_eq_config": null
    }
  ],
  "interfaces": [],
  "vlan_interfaces": [],
  "routes": [
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "interface_name": "phy0",
      "dst": "0.0.0.0/0",
      "gw": "0.0.0.0",
      "vlan_id": null,
      "rib_priority": null
    },
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "interface_name": "phy1",
      "dst": "0.0.0.0/0",
      "gw": "10.85.0.1",
      "vlan_id": null,
      "rib_priority": null
    }
  ],
  "bgp_peers": [],
  "addresses": [
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "address_lot_id": "8d2399d5-1e15-4543-9131-8ea2e1052360",
      "address_lot_name": "example",
      "address_lot_block_id": "470a0e39-78d0-4eab-8743-3de123d347ee",
      "address": "10.85.0.22/32",
      "vlan_id": null,
      "interface_name": "phy0"
    },
    {
      "port_settings_id": "238ed760-b2d9-40d9-9c65-1145a9cf5650",
      "address_lot_id": "8d2399d5-1e15-4543-9131-8ea2e1052360",
      "address_lot_name": "example",
      "address_lot_block_id": "470a0e39-78d0-4eab-8743-3de123d347ee",
      "address": "10.85.0.23/32",
      "vlan_id": null,
      "interface_name": "phy1"
    }
  ]
}