-
Notifications
You must be signed in to change notification settings - Fork 63
Use Reconfigurator simulator in planner integration tests #9473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jgallagher
wants to merge
27
commits into
john/reconfigurator-cli-test-api-2
Choose a base branch
from
john/planner-tests-use-reconfigurator-sim
base: john/reconfigurator-cli-test-api-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use Reconfigurator simulator in planner integration tests #9473
jgallagher
wants to merge
27
commits into
john/reconfigurator-cli-test-api-2
from
john/planner-tests-use-reconfigurator-sim
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followon to #9456 and finishes converting the rest of the planner tests to use the simulator.
I think this is a pretty solid win overall; there's a lot less boilerplate (e.g., in just raw LoC we dropped several hundred in the integration test module). I also picked up some small places where our simulator was missing bits we needed from integration tests. The biggest boilerplate reduction is that running the planner changes from this:
to this:
because
siminternally is able to construct all the other args needed for planning. It always uses the latest blueprint and latest inventory collection, which has been fine in practice. (If we needed to run the planner with different ones for some reason, it'd be easy to add arun_planner_with_...-style method to specify different ones.)There are still some rough edges; a couple off the top of my head:
SystemDescriptionhas a set ofactiveandnot_yetNexus zones, but those don't influence the planning runs. Instead, we have to use theset_explicit_{active,not_yet}_nexus_zones()methods onSimConfigBuilder. I haven't dug into this.sim.inventory_edit_latest_low_level(...)calls to make up various statuses. This still feels pretty boilerplate-y but doesn't seem any worse than it was before. I don't know if it makes sense to grow the simulator to contain this kind of status.