Skip to content

Revert 17a0101 and make the enabled Copr repo required instead - #3181

Merged
centosinfra-prod-github-app[bot] merged 1 commit into
packit:mainfrom
nforro:image-build
Aug 31, 2026
Merged

Revert 17a0101 and make the enabled Copr repo required instead#3181
centosinfra-prod-github-app[bot] merged 1 commit into
packit:mainfrom
nforro:image-build

Conversation

@nforro

@nforro nforro commented Aug 31, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Nikola Forró <nforro@redhat.com>
Assisted-by: Claude Sonnet 5 via Claude Code
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:42 PM UTC · Completed 1:56 PM UTC

Commit: 14a3a6e · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.91

@majamassarini majamassarini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@fullsend-ai-review

Copy link
Copy Markdown

Review

Low

  • [edge-case] files/tasks/setup-copr-repos.yaml:30 — The new skip_if_unavailable=False approach prevents silent fallback only when the Copr repo is unreachable. The old post-install check also caught edge cases where the repo is reachable but does not contain the expected package (e.g., package removed from Copr, or dnf resolves from a different enabled repo with a higher-version package). In practice this is unlikely because these Copr repos are purpose-built for these specific packages, and state: latest with a Copr repo typically wins on version. The new approach is standard practice for hardening Copr-based builds.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Aug 31, 2026
@nforro nforro added the mergeit Merge via Zuul label Aug 31, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@centosinfra-prod-github-app
centosinfra-prod-github-app Bot merged commit 897c44a into packit:main Aug 31, 2026
56 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Packit pull requests Aug 31, 2026
@nforro
nforro deleted the image-build branch August 31, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul ready-for-merge All reviewers approved — ready to merge

Projects

Development

Successfully merging this pull request may close these issues.

3 participants