Skip to content

Refine SteveJobs logic to distinguish between upstream and downstream Forgejo events #3182

Description

@betulependule

This is a follow-up to #3154, which added support for handling of downstream Forgejo events by SteveJobs. All Forgejo events are currently assumed to be dist-git related. In order to add support for upstream Forgejo events, make sure SteveJobs differentiates between upstream and downstream events.

Relevant line of code:

# [XXX] this assumes all Forgejo events come from dist-git
# once we add support for Forgejo in the upstream, all forgejo.pr.Comment
# events would be processed in this if branch meant only for dist-git,
# so the decision logic will need to be refined
if isinstance(self.event, (forgejo.pr.Comment, pagure.pr.Comment)):

There may be more lines of code where a similar fix needs to be done.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/forgejoForgejo-forge relatedkind/featureA request, idea, or new functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions