Skip to content

Commit dcb5414

Browse files
committed
fix(tag-input): apply icon spacing and color to static icon elements
1 parent c57f6ac commit dcb5414

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

packages/core/src/components/tag-input/_tag-input.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ $tag-input-icon-padding-large: ($pt-input-height-large - $pt-icon-size-large) *
2222

2323
.#{$ns}-tag-input-icon {
2424
color: var(--bp-typography-color-muted);
25+
display: flex;
2526
margin-left: calc(var(--bp-surface-spacing) * 0.75);
2627
margin-right: calc(var(--bp-surface-spacing) * 1.75);
2728
// margins to center icon in one-line input

packages/core/src/components/tag-input/tagInput.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -317,11 +317,15 @@ export class TagInput extends AbstractPureComponent<TagInputProps, TagInputState
317317
return (
318318
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions -- container delegates interaction to input element
319319
<div className={classes} onBlur={this.handleContainerBlur} onClick={this.handleContainerClick}>
320-
<Icon
321-
className={Classes.TAG_INPUT_ICON}
322-
icon={leftIcon}
323-
size={isLarge ? IconSize.LARGE : IconSize.STANDARD}
324-
/>
320+
{typeof leftIcon === "string" ? (
321+
<Icon
322+
className={Classes.TAG_INPUT_ICON}
323+
icon={leftIcon}
324+
size={isLarge ? IconSize.LARGE : IconSize.STANDARD}
325+
/>
326+
) : leftIcon != null ? (
327+
<span className={Classes.TAG_INPUT_ICON}>{leftIcon}</span>
328+
) : null}
325329
<div className={Classes.TAG_INPUT_VALUES}>
326330
{values.map(this.maybeRenderTag)}
327331
{this.props.children}

0 commit comments

Comments
 (0)