fix tests

Author: jorisvandenbossche

pandas/_libs/ops.pyx

@@ -177,7 +177,7 @@ def vec_compare(ndarray[object] left, ndarray[object] right, object op) -> ndarr
 
 @cython.wraparound(False)
 @cython.boundscheck(False)
-def scalar_binop(object[:] values, object val, object op) -> ndarray:
+def scalar_binop(ndarray[object] values, object val, object op) -> ndarray:
     """
     Apply the given binary operator `op` between each element of the array
     `values` and the scalar `val`.
@@ -214,7 +214,7 @@ def scalar_binop(object[:] values, object val, object op) -> ndarray:
 
 @cython.wraparound(False)
 @cython.boundscheck(False)
-def vec_binop(object[:] left, object[:] right, object op) -> ndarray:
+def vec_binop(ndarray[object] left, ndarray[object] right, object op) -> ndarray:
     """
     Apply the given binary operator `op` pointwise to the elements of
     arrays `left` and `right`.

pandas/tests/arrays/integer/test_indexing.py

@@ -12,7 +12,7 @@ def test_array_setitem_nullable_boolean_mask():
 
 def test_array_setitem():
     # GH 31446
-    arr = pd.Series([1, 2], dtype="Int64").array
+    arr = pd.array([1, 2], dtype="Int64")
     arr[arr > 1] = 1
 
     expected = pd.array([1, 1], dtype="Int64")

pandas/tests/arrays/numpy_/test_numpy.py

@@ -159,13 +159,6 @@ def test_to_numpy():
 # Setitem
 
 
-def test_setitem_series():
-    ser = pd.Series([1, 2, 3])
-    ser.array[0] = 10
-    expected = pd.Series([10, 2, 3])
-    tm.assert_series_equal(ser, expected)
-
-
 def test_setitem(any_numpy_array):
     nparr = any_numpy_array
     arr = NumpyExtensionArray(nparr, copy=True)

pandas/tests/arrays/test_datetimelike.py

@@ -1248,8 +1248,8 @@ def test_invalid_nat_setitem_array(arr, non_casting_nats):
 @pytest.mark.parametrize(
     "arr",
     [
-        pd.date_range("2000", periods=4).array,
-        pd.timedelta_range("2000", periods=4).array,
+        pd.date_range("2000", periods=4).array.copy(),
+        pd.timedelta_range("2000", periods=4).array.copy(),
     ],
 )
 def test_to_numpy_extra(arr):

pandas/tests/extension/test_common.py

@@ -101,5 +101,5 @@ def test_ellipsis_index():
     # String comparison because there's no native way to compare slices.
     # Before the fix for GH#42430, last_item_arg would get set to the 2D slice
     # (Ellipsis, slice(None, 1, None))
-    out = df["col1"].array.last_item_arg
+    out = df["col1"]._values.last_item_arg
     assert str(out) == "slice(None, 1, None)"

pandas/tests/extension/test_numpy.py

@@ -77,7 +77,7 @@ def allow_in_pandas(monkeypatch):
 @pytest.fixture
 def data(allow_in_pandas, dtype):
     if dtype.numpy_dtype == "object":
-        return pd.Series([(i,) for i in range(100)]).array
+        return pd.Series([(i,) for i in range(100)]).array.copy()
     return NumpyExtensionArray(np.arange(1, 101, dtype=dtype._dtype))
 
 

pandas/tests/internals/test_internals.py

@@ -1347,7 +1347,7 @@ def check_series_setitem(self, elem, index: Index, inplace: bool):
             ser[: len(elem)] = elem
 
         if inplace:
-            assert ser.array is arr  # i.e. setting was done inplace
+            assert ser._values is arr  # i.e. setting was done inplace
         else:
             assert ser.dtype == object
 

pandas/tests/series/test_constructors.py

@@ -525,9 +525,9 @@ def test_categorical_sideeffects_free(self):
         # so this WILL change values
         cat = Categorical(["a", "b", "c", "a"])
         s = Series(cat, copy=False)
-        assert s.values is cat
+        assert s._values is cat
         s = s.cat.rename_categories([1, 2, 3])
-        assert s.values is not cat
+        assert s._values is not cat
         exp_s = np.array([1, 2, 3, 1], dtype=np.int64)
         tm.assert_numpy_array_equal(s.__array__(), exp_s)