Skip to content

Conversation

luke396
Copy link
Contributor

@luke396 luke396 commented Jun 12, 2024

@luke396 luke396 requested a review from WillAyd as a code owner June 12, 2024 07:06
@luke396 luke396 marked this pull request as draft June 12, 2024 07:06
@luke396 luke396 marked this pull request as ready for review June 12, 2024 13:58
@mroeschke mroeschke added Groupby Reduction Operations sum, mean, min, max, etc. labels Jun 12, 2024
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good could you add a whatsnew entry in v3.0.0.rst under the groupby section?

@luke396
Copy link
Contributor Author

luke396 commented Jun 13, 2024

Sorry for careless, and whatsnew is added now.

@luke396 luke396 requested a review from mroeschke June 13, 2024 01:40
@mroeschke mroeschke merged commit 6895f74 into pandas-dev:main Jun 14, 2024
@mroeschke
Copy link
Member

Thanks @luke396

@mroeschke mroeschke added this to the 3.0 milestone Jun 14, 2024
@luke396 luke396 deleted the gh58811 branch June 15, 2024 01:46
@luke396 luke396 mentioned this pull request Jun 17, 2024
5 tasks
mroeschke pushed a commit that referenced this pull request Jun 17, 2024
* check uses_mask before

* backup gh

* backup gh
clin1234 pushed a commit to clin1234/pandas that referenced this pull request Jun 18, 2024
* check uses_mask before

* backup gh

* backup gh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Groupby transformation (cumsum) output dtype depends on whether NA is among group labels
2 participants