BUG: Raise ParserWarning when on_bad_lines is callable and index_col is set (GH#61882) #61902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this PR fixes Issue #[61882]. All pre-commit checks pass locally. The CI failures appear unrelated to this change (macOS/Windows builds, Numpy dev, etc.). Please let me know if anything else is needed. |
|
@AbhijitPatill The PR includes over 5,000 file changes — could you double-check if the branch was created from main correctly? Also, I suggest waiting for confirmation from a core member before opening a PR for any issue. |
that is a merged PR relating to datetime. What's the issue with csv parsing? |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #61882. It raises a
ParserWarningwhenon_bad_linesis a callable andindex_colis set, since this combination can lead to unexpected behavior.A test was added in
test_read_csv_warn.pyto ensure the warning is raised appropriately.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.