Skip to content

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Aug 12, 2025

First time contributor here.

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number) No issue related
  • [ ] Tests added and passed if fixing a bug or adding a new feature
  • [ ] All code checks passed.
  • [ ] Added type annotations to new arguments/methods/functions. Nothing new
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Add to_julian_date documentation entry to pandas.DatetimeIndex.

Currently, it is not listed nor can be found in the documentation: https://pandas.pydata.org/docs/reference/api/pandas.DatetimeIndex.html
pandas.Timestamp already has it linked https://pandas.pydata.org/docs/reference/api/pandas.Timestamp.to_julian_date.html
from the time it was added v0.14.0 https://pandas.pydata.org/docs/whatsnew/v0.14.0.html

I haven't read through the contributing section, please point out if there is something missing. If it looks okay, tell me to proceed with the whatsnew task.

Docs artifact for second commit (it works): https://github.com/pandas-dev/pandas/actions/runs/16895776565/job/47865152612?pr=62090

@echedey-ls echedey-ls marked this pull request as ready for review August 12, 2025 01:02
Validate Docstrings
Error: /home/runner/work/pandas/pandas/pandas/core/indexes/datetimes.py:296:SS06:pandas.DatetimeIndex.to_julian_date:Summary should fit in a single line
Error: /home/runner/work/pandas/pandas/pandas/core/indexes/datetimes.py:296:SS03:pandas.DatetimeIndex.to_julian_date:Summary does not end with a period
Error: /home/runner/work/pandas/pandas/pandas/core/indexes/datetimes.py:296:EX01:pandas.DatetimeIndex.to_julian_date:No examples section found
Error: /home/runner/work/pandas/pandas/pandas/core/indexes/datetimes.py:296:RT01:pandas.DatetimeIndex.to_julian_date:No Returns section found
Error: /home/runner/work/pandas/pandas/pandas/core/indexes/datetimes.py:296:SA01:pandas.DatetimeIndex.to_julian_date:See Also section not found
Validate Docstrings DONE
Error: Process completed with exit code 5.
@echedey-ls echedey-ls changed the title Add to_julian_date to DatetimeIndex methods listing DOC: Add to_julian_date to DatetimeIndex methods listing Aug 12, 2025
@mroeschke mroeschke added the Docs label Aug 13, 2025
@mroeschke mroeschke added this to the 3.0 milestone Aug 13, 2025
@mroeschke mroeschke merged commit 5774290 into pandas-dev:main Aug 13, 2025
42 checks passed
@mroeschke
Copy link
Member

Thanks @echedey-ls

@echedey-ls echedey-ls deleted the patch-1 branch August 14, 2025 01:49
eicchen pushed a commit to eicchen/pandas that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants