BUG: Preserve day freq on DatetimeIndex subtraction #62096
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshat62
changed the title
akshat62
force-pushed
the
bug-62094/freq-required-TimedeltaIndex.shift
branch
from
7280c6a to
ed516d9
Compare
|
@mroeschke @jbrockmendel Please review. |
| @@ -758,6 +758,10 @@ Datetimelike | |||
| - Bug in :meth:`to_datetime` reports incorrect index in case of any failure scenario. (:issue:`58298`) | |||
| - Bug in :meth:`to_datetime` with ``format="ISO8601"`` and ``utc=True`` where naive timestamps incorrectly inherited timezone offset from previous timestamps in a series. (:issue:`61389`) | |||
| - Bug in :meth:`to_datetime` wrongly converts when ``arg`` is a ``np.datetime64`` object with unit of ``ps``. (:issue:`60341`) | |||
| - Bug in subtracting a :class:`Timestamp` from a :class:`DatetimeIndex` with | |||
There was a problem hiding this comment.
the note isn't necessary bc the bug is not present in a released version
| and isinstance(other, Timestamp) | ||
| ): | ||
| self = cast("DatetimeArray", self) | ||
| if (self.tz is None or timezones.is_utc(self.tz)) and ( |
There was a problem hiding this comment.
self.tz is None is implied by lib.is_np_dtype(self.dtype, "M") check above
| ): | ||
| self = cast("DatetimeArray", self) | ||
| if (self.tz is None or timezones.is_utc(self.tz)) and ( | ||
| other.tz is None or timezones.is_utc(other.tz) |
There was a problem hiding this comment.
other.tz will always be None here
| @@ -74,3 +74,10 @@ def test_shift_no_freq(self): | |||
| tdi = TimedeltaIndex(["1 days 01:00:00", "2 days 01:00:00"], freq=None) | |||
| with pytest.raises(NullFrequencyError, match="Cannot shift with no freq"): | |||
| tdi.shift(2) | |||
|
|
|||
| def test_shift_after_dti_sub_timestamp(self): | |||
There was a problem hiding this comment.
instead of testing this, test the subtraction op directly in tests.indexes.datetimes.test_arithmetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.