BUG/TST: Series round with dtype object #62174
Open
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/series.py
Outdated
| return self._constructor( | ||
| new_values, index=self.index, copy=False | ||
| ).__finalize__(self, method="map") | ||
| except TypeError as e: |
There was a problem hiding this comment.
nitpick e->err. try to avoid single-letter variable names
pandas/core/series.py
Outdated
| raise TypeError("Expected numeric dtype, got object instead.") | ||
| try: | ||
| round_func = functools.partial(round, ndigits=decimals) | ||
| new_values = self._map_values(round_func) |
There was a problem hiding this comment.
only this line needs to go inside the try/except
In another PR you're going to make DataFrame do the same thing this does, right? If so, you'll need to change the Block behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I changed the behavior or series.round() to act like
series.map(round)if the dtype is object as discussed in #61682. I put this in a new PR as the original intent of the other PR was to change DataFrame behavior. I'm unsure if the way I approached it is a good way to make the change though because I saw incore/internals/blocks.pythatBlock'sround()method is intended to raise an error for dtype of object. So I wasn't sure I should approach this by updated theBlockclass instead. Any feedback is appreciated!