- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.1k
 
Closed
Labels
A-cliRelated to the reth CLIRelated to the reth CLIA-observabilityRelated to tracing, metrics, logs and other observability toolsRelated to tracing, metrics, logs and other observability toolsC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Description
Describe the feature
currently we log:
- Shanghai                         @0
- Cancun                           @0
- Prague                           @0
- Osaka                            @15000
reth/crates/ethereum/hardforks/src/display.rs
Lines 144 to 148 in 5e2ed16
| /// Creates a new [`DisplayHardforks`] from an iterator of hardforks. | |
| pub fn new<'a, I>(hardforks: I) -> Self | |
| where | |
| I: IntoIterator<Item = (&'a dyn Hardfork, ForkCondition)>, | |
| { | 
but ideally we also want to log the blob settings:
INFO [10-27|13:09:17.657]  - Cancun:                      @0          blob: (target: 3, max: 6, fraction: 3338477)
INFO [10-27|13:09:17.657]  - Prague:                      @0          blob: (target: 6, max: 9, fraction: 5007716)
INFO [10-27|13:09:17.657]  - Osaka:                       @15000      blob: (target: 6, max: 9, fraction: 5007716)
to do this we need to add optional metadata to displayhardfork
reth/crates/ethereum/hardforks/src/display.rs
Lines 21 to 30 in 5e2ed16
| struct DisplayFork { | |
| /// The name of the hardfork (e.g. Frontier) | |
| name: String, | |
| /// The fork condition | |
| activated_at: ForkCondition, | |
| /// An optional EIP (e.g. `EIP-1559`). | |
| eip: Option<String>, | |
| } | |
| impl core::fmt::Display for DisplayFork { | 
and provide this as string input
TODO
- add 
DisplayHardforks::with_metaso that this also accepts optional string context(iterator (hardfork, condition, Option<String>)) - update display impl for 
DisplayFork - update ethereum callsite: so that this also gets the the blobparam for the hardforks:
reth/crates/chainspec/src/spec.rs
Line 443 in 5e2ed16
DisplayHardforks::new(self.hardforks.forks_iter()) reth/crates/chainspec/src/spec.rs
Lines 316 to 317 in 5e2ed16
/// The settings passed for blob configurations for specific hardforks. pub blob_params: BlobScheduleBlobParams,  
Additional context
No response
Metadata
Metadata
Assignees
Labels
A-cliRelated to the reth CLIRelated to the reth CLIA-observabilityRelated to tracing, metrics, logs and other observability toolsRelated to tracing, metrics, logs and other observability toolsC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Type
Projects
Status
Done